feat(flagd): Improve e2e coverage #1092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Schrottner <[email protected]>
github-actions
bot
requested review from
beeme1mr,
Kavindu-Dodan,
thisthat and
toddbaert
Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
feat/use_more_gherkin_files
branch
from
14c07c9 to
4c9010f
Compare
toddbaert
reviewed
Dec 4, 2024
toddbaert
reviewed
Dec 4, 2024
...flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/RunFlagdRpcCucumberTest.java
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Dec 4, 2024
...lagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/config/ConfigSteps.java
Show resolved
Hide resolved
toddbaert
reviewed
Dec 4, 2024
...lagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/config/ConfigSteps.java
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Dec 4, 2024
There was a problem hiding this comment.
I see this as pretty useful, though the mileage may very depending on whether or not the implementation exposes a config object that can be independently tested.
I would also prefer to somehow mark this gherkin feature file as a "unit" style test somehow (perhaps make the extension .unit.feature?)
I also would prefer the passive voice is used: https://github.com/open-feature/java-sdk-contrib/pull/1092/files#r1870241239
Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
feat/use_more_gherkin_files
branch
from
8a0e6e1 to
ac044fd
Compare
aepfli
commented
Dec 18, 2024
Signed-off-by: Simon Schrottner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the newest gherkin files to the release, one for config, and one to ensure caching is working properly