Skip to content

feat: Improve wait logic to a more elegant solution #1160 #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Feb 26, 2025
Merged

feat: Improve wait logic to a more elegant solution #1160 #1169

merged 22 commits into from
Feb 26, 2025

Conversation

chrfwow
Copy link
Contributor

@chrfwow chrfwow commented Jan 21, 2025 •
edited
Loading

This PR

Adds a better wait logic to wait for the initialization of the FlagdProvider.

With these changes, it is not advisable to restart a FlagdProvider once it has been shut down.

Related Issues

Fixes #1160

@chrfwow
feat: improve wait logic to a more elegant solution open-feature#1160
4402e66 
Signed-off-by: christian.lutnik <[email protected]>
@chrfwow
Merge branch 'refs/heads/main' into improve-wait-logic-to-a-more-eleg…
99dda5c 
…ant-solution-open-feature#1160

# Conflicts:
#	providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java
#	providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java
#	providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolverTest.java
@chrfwow
fixup! feat: improve wait logic to a more elegant solution open-featu…
a41e980 
…re#1160

Signed-off-by: christian.lutnik <[email protected]>
@chrfwow chrfwow marked this pull request as ready for review January 21, 2025 10:24
@chrfwow chrfwow requested a review from a team as a code owner January 21, 2025 10:24
aepfli
aepfli approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you - i just added some questions and suggestions, nothing crucial except the one about where we are doing this wait and notify

@chrfwow chrfwow marked this pull request as draft January 22, 2025 08:12
@chrfwow chrfwow mentioned this pull request Jan 23, 2025
Closed
@chrfwow
Copy link
Contributor Author

chrfwow commented Jan 29, 2025 •
edited
Loading

Waiting on open-feature/java-sdk#1299 completed

@chrfwow
Merge branch 'main' into improve-wait-logic-to-a-more-elegant-solution-…
bee7edd 
…open-feature#1160

# Conflicts:
#	providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java
@chrfwow
merge with master branch
7d2022d 
Signed-off-by: christian.lutnik <[email protected]>
@chrfwow
revert cucumber changes
97bdaba 
Signed-off-by: christian.lutnik <[email protected]>
@chrfwow
increase sleep to "fix" flaky tests
9a32b22 
Signed-off-by: christian.lutnik <[email protected]>
@chrfwow
increase sleep to "fix" flaky tests
29a4260 
Signed-off-by: christian.lutnik <[email protected]>
@chrfwow
increase sleep to "fix" flaky tests
89f4d1e 
Signed-off-by: christian.lutnik <[email protected]>
@chrfwow chrfwow marked this pull request as ready for review February 18, 2025 13:20
@chrfwow
reintroduce names for providers
619a67f 
Signed-off-by: christian.lutnik <[email protected]>
@chrfwow
Merge branch 'main' into improve-wait-logic-to-a-more-elegant-solution-…
2c9c843 
…open-feature#1160

# Conflicts:
#	providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java
#	providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/EventSteps.java
@chrfwow
merge with main
c2024e7 
Signed-off-by: christian.lutnik <[email protected]>
@chrfwow chrfwow requested review from gruebel and liran2000 February 25, 2025 07:24
@toddbaert
Copy link
Member

I'll be sure to review this tomrrow.

toddbaert
toddbaert reviewed Feb 25, 2025
View reviewed changes
toddbaert
toddbaert approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🙏

@toddbaert
Copy link
Member

I'll merge this tomorrow unless I hear objections.

@toddbaert toddbaert merged commit 4f484b7 into open-feature:main Feb 26, 2025
5 checks passed
@github-actions github-actions bot mentioned this pull request Feb 26, 2025
Merged
@github-actions github-actions bot mentioned this pull request Apr 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aepfli aepfli aepfli approved these changes

@toddbaert toddbaert toddbaert approved these changes

@beeme1mr beeme1mr Awaiting requested review from beeme1mr

@Kavindu-Dodan Kavindu-Dodan Awaiting requested review from Kavindu-Dodan

@thisthat thisthat Awaiting requested review from thisthat

@alexandraoberaigner alexandraoberaigner Awaiting requested review from alexandraoberaigner

@guidobrei guidobrei Awaiting requested review from guidobrei

@gruebel gruebel Awaiting requested review from gruebel

@liran2000 liran2000 Awaiting requested review from liran2000

Assignees

@beeme1mr beeme1mr

@thisthat thisthat

@Kavindu-Dodan Kavindu-Dodan

@toddbaert toddbaert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[flagd] improve wait logic to a more elegant solution
6 participants
@chrfwow @toddbaert @aepfli @beeme1mr @thisthat @Kavindu-Dodan