various improvements as suggested by sonar

Signed-off-by: Kavindu Dodanduwa <[email protected]>

Author: Kavindu-Dodan

src/main/java/dev/openfeature/sdk/EventSupport.java

@@ -163,8 +163,8 @@ static class HandlerStore {
 
         private final Map<ProviderEvent, List<Consumer<EventDetails>>> handlerMap;
 
-        {
-            handlerMap = new ConcurrentHashMap<ProviderEvent, List<Consumer<EventDetails>>>();
+        HandlerStore() {
+            handlerMap = new ConcurrentHashMap<>();
             handlerMap.put(ProviderEvent.PROVIDER_READY, new ArrayList<>());
             handlerMap.put(ProviderEvent.PROVIDER_CONFIGURATION_CHANGED, new ArrayList<>());
             handlerMap.put(ProviderEvent.PROVIDER_ERROR, new ArrayList<>());

src/main/java/dev/openfeature/sdk/ImmutableStructure.java

@@ -40,7 +40,7 @@ public ImmutableStructure(Map<String, Value> attributes) {
                 .collect(HashMap::new,
                         (accumulated, entry) -> accumulated.put(entry.getKey(),
                                 Optional.ofNullable(entry.getValue())
-                                    .map(e -> e.clone())
+                                    .map(Value::copy)
                                     .orElse(null)),
                         HashMap::putAll)));
     }
@@ -54,7 +54,7 @@ public Set<String> keySet() {
     @Override
     public Value getValue(String key) {
         Value value = this.attributes.get(key);
-        return value != null ? value.clone() : null;
+        return value != null ? value.copy() : null;
     }
 
     /**
@@ -70,7 +70,7 @@ public Map<String, Value> asMap() {
                 .collect(HashMap::new,
                         (accumulated, entry) -> accumulated.put(entry.getKey(),
                                 Optional.ofNullable(entry.getValue())
-                                .map(e -> e.clone())
+                                .map(Value::copy)
                                 .orElse(null)),
                         HashMap::putAll);
     }

src/main/java/dev/openfeature/sdk/MutableContext.java

@@ -145,7 +145,7 @@ public MutableStructure add(String ignoredKey, List<Value> ignoredValue) {
             return null;
         }
 
-        public MutableStructure add(String ignoredKey, MutableStructure ignoredValue) {
+        public MutableStructure add(String ignoredKey, Structure ignoredValue) {
             return null;
         }
 

src/main/java/dev/openfeature/sdk/MutableStructure.java

@@ -75,7 +75,7 @@ public MutableStructure add(String key, Structure value) {
         return this;
     }
 
-    public <T> MutableStructure add(String key, List<Value> value) {
+    public MutableStructure add(String key, List<Value> value) {
         attributes.put(key, new Value(value));
         return this;
     }

src/main/java/dev/openfeature/sdk/NoOpProvider.java

@@ -18,12 +18,7 @@ public ProviderState getState() {
 
     @Override
     public Metadata getMetadata() {
-        return new Metadata() {
-            @Override
-            public String getName() {
-                return name;
-            }
-        };
+        return () -> name;
     }
 
     @Override

src/main/java/dev/openfeature/sdk/ProviderRepository.java

@@ -168,7 +168,6 @@ private boolean isProviderRegistered(FeatureProvider provider) {
     private void shutdownProvider(FeatureProvider provider) {
         taskExecutor.submit(() -> {
             try {
-                // detachProviderEvents(provider);
                 provider.shutdown();
             } catch (Exception e) {
                 log.error("Exception when shutting down feature provider {}", provider.getClass().getName(), e);

src/main/java/dev/openfeature/sdk/Value.java

@@ -20,7 +20,7 @@
 @ToString
 @EqualsAndHashCode
 @SuppressWarnings({"PMD.BeanMembersShouldSerialize", "checkstyle:MissingJavadocType", "checkstyle:NoFinalizer"})
-public class Value implements Cloneable {
+public class Value {
 
     private final Object innerObject;
 
@@ -262,14 +262,12 @@ public Instant asInstant() {
     }
 
     /**
-     * Perform deep clone of value object.
+     * Perform a deep copy of this value.
      *
      * @return Value
      */
-
     @SneakyThrows
-    @Override
-    protected Value clone() {
+    protected Value copy() {
         if (this.isList()) {
             List<Value> copy = this.asList().stream().map(Value::new).collect(Collectors.toList());
             return new Value(copy);

src/main/java/dev/openfeature/sdk/providers/memory/InMemoryProvider.java

@@ -52,6 +52,7 @@ public InMemoryProvider(Map<String, Flag<?>> flags) {
      * @param evaluationContext evaluation context
      * @throws Exception on error
      */
+    @Override
     public void initialize(EvaluationContext evaluationContext) throws Exception {
         super.initialize(evaluationContext);
         state = ProviderState.READY;