Skip to content

Commit 4dc988b

Browse files
jarebudevaepfli
andauthored
feat!: Raise required Java version to 11 (#1393)
* bumped to java 11, altered CI to target java 11 Signed-off-by: jarebudev <[email protected]> * changed profile and toolchain Signed-off-by: jarebudev <[email protected]> * corrected toolchain version Signed-off-by: jarebudev <[email protected]> --------- Signed-off-by: jarebudev <[email protected]> Co-authored-by: Simon Schrottner <[email protected]>
1 parent f2348ea commit 4dc988b

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

.github/workflows/pullrequest.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@ jobs:
1313
build:
1414
- java: 17
1515
profile: codequality
16-
- java: 8
17-
profile: java8
16+
- java: 11
17+
profile: java11
1818
name: with Java ${{ matrix.build.java }}
1919
runs-on: ${{ matrix.os}}
2020
steps:
2121
- name: Check out the code
2222
uses: actions/checkout@85e6279cec87321a52edac9c87bce653a07cf6c2
2323

24-
- name: Set up JDK 8
24+
- name: Set up JDK 11
2525
uses: actions/setup-java@f4f1212c880fdec8162ea9a6493f4495191887b4
2626
with:
2727
java-version: ${{ matrix.build.java }}

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646

4747
### Requirements
4848

49-
- Java 8+ (compiler target is 1.8)
49+
- Java 11+ (compiler target is 11)
5050

5151
Note that this library is intended to be used in server-side contexts and has not been evaluated for use on mobile devices.
5252

pom.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<properties>
1111
<toolchain.jdk.version>[17,)</toolchain.jdk.version>
1212
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
13-
<maven.compiler.source>1.8</maven.compiler.source>
13+
<maven.compiler.source>11</maven.compiler.source>
1414
<maven.compiler.target>${maven.compiler.source}</maven.compiler.target>
1515
<junit.jupiter.version>5.12.2</junit.jupiter.version>
1616
<io.cucumber.version>7.22.1</io.cucumber.version>
@@ -20,7 +20,7 @@
2020
<module-name>${project.groupId}.${project.artifactId}</module-name>
2121
<skip.tests>false</skip.tests>
2222
<!-- this will throw an error if we use wrong apis -->
23-
<maven.compiler.release>8</maven.compiler.release>
23+
<maven.compiler.release>11</maven.compiler.release>
2424
</properties>
2525

2626
<name>OpenFeature Java SDK</name>
@@ -646,14 +646,14 @@
646646
</plugins>
647647
</build>
648648
</profile>
649-
<!-- profile for running tests under java 8 (used mostly in CI) -->
650-
<!-- selected automatically by JDK activeation (see https://maven.apache.org/guides/introduction/introduction-to-profiles.html#implicit-profile-activation) -->
649+
<!-- profile for running tests under java 11 (used mostly in CI) -->
650+
<!-- selected automatically by JDK activation (see https://maven.apache.org/guides/introduction/introduction-to-profiles.html#implicit-profile-activation) -->
651651
<profile>
652-
<id>java8</id>
652+
<id>java11</id>
653653
<!-- with the next block we can define a set of sdks which still support java 8, if any of the sdks is not supporting java 8 anymore -->
654654
<!--<modules><module></module></modules>-->
655655
<properties>
656-
<toolchain.jdk.version>(1.8,9)</toolchain.jdk.version>
656+
<toolchain.jdk.version>[11,)</toolchain.jdk.version>
657657
<skip.tests>true</skip.tests>
658658
</properties>
659659

0 commit comments

Comments
 (0)