Skip to content

Commit 8c595b0

Browse files
authored
fix: RejectedExecutionException on shutdown (#652)
Signed-off-by: Todd Baert <[email protected]>
1 parent b77e44e commit 8c595b0

File tree

2 files changed

+0
-19
lines changed

2 files changed

+0
-19
lines changed

src/main/java/dev/openfeature/sdk/ProviderRepository.java

-10
Original file line numberDiff line numberDiff line change
@@ -171,16 +171,6 @@ public void shutdown() {
171171
.concat(Stream.of(this.defaultProvider.get()), this.providers.values().stream())
172172
.distinct()
173173
.forEach(this::shutdownProvider);
174-
setProvider(new NoOpProvider(),
175-
(FeatureProvider fp) -> {
176-
},
177-
(FeatureProvider fp) -> {
178-
},
179-
(FeatureProvider fp) -> {
180-
},
181-
(FeatureProvider fp,
182-
String message) -> {
183-
}, false);
184174
this.providers.clear();
185175
taskExecutor.shutdown();
186176
}

src/test/java/dev/openfeature/sdk/ProviderRepositoryTest.java

-9
Original file line numberDiff line numberDiff line change
@@ -296,15 +296,6 @@ void shouldShutdownAllFeatureProvidersOnShutdown() {
296296
setFeatureProvider(ANOTHER_CLIENT_NAME, featureProvider2);
297297

298298
providerRepository.shutdown();
299-
300-
await()
301-
.pollDelay(Duration.ofMillis(1))
302-
.atMost(Duration.ofSeconds(TIMEOUT))
303-
.untilAsserted(() -> {
304-
assertThat(providerRepository.getProvider()).isInstanceOf(NoOpProvider.class);
305-
assertThat(providerRepository.getProvider(CLIENT_NAME)).isInstanceOf(NoOpProvider.class);
306-
assertThat(providerRepository.getProvider(ANOTHER_CLIENT_NAME)).isInstanceOf(NoOpProvider.class);
307-
});
308299
verify(featureProvider1, timeout(TIMEOUT)).shutdown();
309300
verify(featureProvider2, timeout(TIMEOUT)).shutdown();
310301
}

0 commit comments

Comments
 (0)