Skip to content

Commit cf4be29

Browse files
committed
fixup: await verify
Signed-off-by: Todd Baert <[email protected]>
1 parent 69f3976 commit cf4be29

File tree

1 file changed

+15
-12
lines changed

1 file changed

+15
-12
lines changed

src/test/java/dev/openfeature/sdk/providers/memory/InMemoryProviderTest.java

+15-12
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import dev.openfeature.sdk.EventDetails;
66
import dev.openfeature.sdk.ImmutableContext;
77
import dev.openfeature.sdk.OpenFeatureAPI;
8+
import dev.openfeature.sdk.ProviderState;
89
import dev.openfeature.sdk.Value;
910
import dev.openfeature.sdk.exceptions.FlagNotFoundError;
1011
import dev.openfeature.sdk.exceptions.ProviderNotReadyError;
@@ -27,6 +28,7 @@
2728
import static org.junit.jupiter.api.Assertions.assertEquals;
2829
import static org.junit.jupiter.api.Assertions.assertThrows;
2930
import static org.junit.jupiter.api.Assertions.assertTrue;
31+
import static org.awaitility.Awaitility.await;
3032
import static org.mockito.ArgumentMatchers.any;
3133
import static org.mockito.ArgumentMatchers.argThat;
3234
import static org.mockito.Mockito.mock;
@@ -45,15 +47,16 @@ class InMemoryProviderTest {
4547
void beforeEach() {
4648
Map<String, Flag<?>> flags = buildFlags();
4749
provider = spy(new InMemoryProvider(flags));
48-
OpenFeatureAPI.getInstance().onProviderConfigurationChanged(eventDetails -> {});
50+
OpenFeatureAPI.getInstance().onProviderConfigurationChanged(eventDetails -> {
51+
});
4952
OpenFeatureAPI.getInstance().setProviderAndWait(provider);
5053
client = OpenFeatureAPI.getInstance().getClient();
5154
provider.updateFlags(flags);
5255
provider.updateFlag("addedFlag", Flag.builder()
53-
.variant("on", true)
54-
.variant("off", false)
55-
.defaultVariant("on")
56-
.build());
56+
.variant("on", true)
57+
.variant("off", false)
58+
.defaultVariant("on")
59+
.build());
5760
}
5861

5962
@SneakyThrows
@@ -85,10 +88,9 @@ void getDoubleEvaluation() {
8588
@Test
8689
void getObjectEvaluation() {
8790
Value expectedObject = new Value(mapToStructure(ImmutableMap.of(
88-
"showImages", new Value(true),
89-
"title", new Value("Check out these pics!"),
90-
"imagesPerPage", new Value(100)
91-
)));
91+
"showImages", new Value(true),
92+
"title", new Value("Check out these pics!"),
93+
"imagesPerPage", new Value(100))));
9294
assertEquals(expectedObject, client.getObjectValue("object-flag", new Value(true)));
9395
}
9496

@@ -112,7 +114,8 @@ void shouldThrowIfNotInitialized() {
112114
InMemoryProvider inMemoryProvider = new InMemoryProvider(new HashMap<>());
113115

114116
// ErrorCode.PROVIDER_NOT_READY should be returned when evaluated via the client
115-
assertThrows(ProviderNotReadyError.class, ()-> inMemoryProvider.getBooleanEvaluation("fail_not_initialized", false, new ImmutableContext()));
117+
assertThrows(ProviderNotReadyError.class,
118+
() -> inMemoryProvider.getBooleanEvaluation("fail_not_initialized", false, new ImmutableContext()));
116119
}
117120

118121
@SuppressWarnings("unchecked")
@@ -126,8 +129,8 @@ void emitChangedFlagsOnlyIfThereAreChangedFlags() {
126129

127130
provider.updateFlags(flags);
128131

129-
verify(handler, times(1))
130-
.accept(argThat(details -> details.getFlagsChanged().isEmpty()));
132+
await().untilAsserted(() -> verify(handler, times(1))
133+
.accept(argThat(details -> details.getFlagsChanged().isEmpty())));
131134
}
132135

133136
@Test

0 commit comments

Comments
 (0)