Skip to content

Commit ecfeddf

Browse files
authored
chore: rename flag metadata (#478)
Signed-off-by: Todd Baert <[email protected]>
1 parent 3501425 commit ecfeddf

File tree

5 files changed

+23
-23
lines changed

5 files changed

+23
-23
lines changed

src/main/java/dev/openfeature/sdk/FlagEvaluationDetails.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public class FlagEvaluationDetails<T> implements BaseEvaluation<T> {
2020
@Nullable private String reason;
2121
private ErrorCode errorCode;
2222
@Nullable private String errorMessage;
23-
@Builder.Default private FlagMetadata flagMetadata = FlagMetadata.builder().build();
23+
@Builder.Default private ImmutableMetadata flagMetadata = ImmutableMetadata.builder().build();
2424

2525
/**
2626
* Generate detail payload from the provider response.

src/main/java/dev/openfeature/sdk/FlagMetadata.java renamed to src/main/java/dev/openfeature/sdk/ImmutableMetadata.java

+17-17
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010
* through builder and accessors.
1111
*/
1212
@Slf4j
13-
public class FlagMetadata {
13+
public class ImmutableMetadata {
1414
private final Map<String, Object> metadata;
1515

16-
private FlagMetadata(Map<String, Object> metadata) {
16+
private ImmutableMetadata(Map<String, Object> metadata) {
1717
this.metadata = metadata;
1818
}
1919

@@ -98,19 +98,19 @@ public <T> T getValue(final String key, final Class<T> type) {
9898

9999

100100
/**
101-
* Obtain a builder for {@link FlagMetadata}.
101+
* Obtain a builder for {@link ImmutableMetadata}.
102102
*/
103-
public static FlagMetadataBuilder builder() {
104-
return new FlagMetadataBuilder();
103+
public static ImmutableMetadataBuilder builder() {
104+
return new ImmutableMetadataBuilder();
105105
}
106106

107107
/**
108-
* Immutable builder for {@link FlagMetadata}.
108+
* Immutable builder for {@link ImmutableMetadata}.
109109
*/
110-
public static class FlagMetadataBuilder {
110+
public static class ImmutableMetadataBuilder {
111111
private final Map<String, Object> metadata;
112112

113-
private FlagMetadataBuilder() {
113+
private ImmutableMetadataBuilder() {
114114
metadata = new HashMap<>();
115115
}
116116

@@ -120,7 +120,7 @@ private FlagMetadataBuilder() {
120120
* @param key flag metadata key to add
121121
* @param value flag metadata value to add
122122
*/
123-
public FlagMetadataBuilder addString(final String key, final String value) {
123+
public ImmutableMetadataBuilder addString(final String key, final String value) {
124124
metadata.put(key, value);
125125
return this;
126126
}
@@ -131,7 +131,7 @@ public FlagMetadataBuilder addString(final String key, final String value) {
131131
* @param key flag metadata key to add
132132
* @param value flag metadata value to add
133133
*/
134-
public FlagMetadataBuilder addInteger(final String key, final Integer value) {
134+
public ImmutableMetadataBuilder addInteger(final String key, final Integer value) {
135135
metadata.put(key, value);
136136
return this;
137137
}
@@ -142,7 +142,7 @@ public FlagMetadataBuilder addInteger(final String key, final Integer value) {
142142
* @param key flag metadata key to add
143143
* @param value flag metadata value to add
144144
*/
145-
public FlagMetadataBuilder addLong(final String key, final Long value) {
145+
public ImmutableMetadataBuilder addLong(final String key, final Long value) {
146146
metadata.put(key, value);
147147
return this;
148148
}
@@ -153,7 +153,7 @@ public FlagMetadataBuilder addLong(final String key, final Long value) {
153153
* @param key flag metadata key to add
154154
* @param value flag metadata value to add
155155
*/
156-
public FlagMetadataBuilder addFloat(final String key, final Float value) {
156+
public ImmutableMetadataBuilder addFloat(final String key, final Float value) {
157157
metadata.put(key, value);
158158
return this;
159159
}
@@ -164,7 +164,7 @@ public FlagMetadataBuilder addFloat(final String key, final Float value) {
164164
* @param key flag metadata key to add
165165
* @param value flag metadata value to add
166166
*/
167-
public FlagMetadataBuilder addDouble(final String key, final Double value) {
167+
public ImmutableMetadataBuilder addDouble(final String key, final Double value) {
168168
metadata.put(key, value);
169169
return this;
170170
}
@@ -175,16 +175,16 @@ public FlagMetadataBuilder addDouble(final String key, final Double value) {
175175
* @param key flag metadata key to add
176176
* @param value flag metadata value to add
177177
*/
178-
public FlagMetadataBuilder addBoolean(final String key, final Boolean value) {
178+
public ImmutableMetadataBuilder addBoolean(final String key, final Boolean value) {
179179
metadata.put(key, value);
180180
return this;
181181
}
182182

183183
/**
184-
* Retrieve {@link FlagMetadata} with provided key,value pairs.
184+
* Retrieve {@link ImmutableMetadata} with provided key,value pairs.
185185
*/
186-
public FlagMetadata build() {
187-
return new FlagMetadata(this.metadata);
186+
public ImmutableMetadata build() {
187+
return new ImmutableMetadata(this.metadata);
188188
}
189189

190190
}

src/main/java/dev/openfeature/sdk/ProviderEvaluation.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@ public class ProviderEvaluation<T> implements BaseEvaluation<T> {
1414
ErrorCode errorCode;
1515
@Nullable private String errorMessage;
1616
@Builder.Default
17-
private FlagMetadata flagMetadata = FlagMetadata.builder().build();
17+
private ImmutableMetadata flagMetadata = ImmutableMetadata.builder().build();
1818
}

src/test/java/dev/openfeature/sdk/DoSomethingProvider.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ class DoSomethingProvider implements FeatureProvider {
44

55
static final String name = "Something";
66
// Flag evaluation metadata
7-
static final FlagMetadata flagMetadata = FlagMetadata.builder().build();
7+
static final ImmutableMetadata flagMetadata = ImmutableMetadata.builder().build();
88

99
private EvaluationContext savedContext;
1010

src/test/java/dev/openfeature/sdk/FlagMetadataTest.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ class FlagMetadataTest {
1111
@DisplayName("Test metadata payload construction and retrieval")
1212
public void builder_validation() {
1313
// given
14-
FlagMetadata flagMetadata = FlagMetadata.builder()
14+
ImmutableMetadata flagMetadata = ImmutableMetadata.builder()
1515
.addString("string", "string")
1616
.addInteger("integer", 1)
1717
.addLong("long", 1L)
@@ -44,7 +44,7 @@ public void builder_validation() {
4444
@DisplayName("Value type mismatch returns a null")
4545
public void value_type_validation() {
4646
// given
47-
FlagMetadata flagMetadata = FlagMetadata.builder()
47+
ImmutableMetadata flagMetadata = ImmutableMetadata.builder()
4848
.addString("string", "string")
4949
.build();
5050

@@ -56,7 +56,7 @@ public void value_type_validation() {
5656
@DisplayName("A null is returned if key does not exist")
5757
public void notfound_error_validation() {
5858
// given
59-
FlagMetadata flagMetadata = FlagMetadata.builder().build();
59+
ImmutableMetadata flagMetadata = ImmutableMetadata.builder().build();
6060

6161
// then
6262
assertThat(flagMetadata.getBoolean("string")).isNull();

0 commit comments

Comments
 (0)