Skip to content

Commit 1ee3395

Browse files
committed
fix(flagd): skip handling "None"
1 parent 9e92513 commit 1ee3395

File tree

3 files changed

+2
-14
lines changed

3 files changed

+2
-14
lines changed

providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/in_process.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,8 @@ def _resolve(
121121
)
122122

123123
variant, value = flag.get_variant(variant)
124+
if value is None:
125+
raise ParseError(f"Resolved variant {variant} not in variants config.")
124126

125127
return FlagResolutionDetails(
126128
value,

providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/flags.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,4 @@ def get_variant(
9090
if isinstance(variant_key, bool):
9191
variant_key = str(variant_key).lower()
9292

93-
if variant_key not in self.variants:
94-
raise ParseError(f"Resolved variant {variant_key} not in variants config.")
95-
9693
return variant_key, self.variants.get(variant_key)

providers/openfeature-provider-flagd/tests/test_in_process.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -195,16 +195,6 @@ def test_resolve_boolean_details_invalid_variant(resolver, flag):
195195
"target_variant",
196196
{},
197197
),
198-
(
199-
{"default_variant": None, "target_variant": None},
200-
targeting(),
201-
context("target_variant"),
202-
"resolve_object_details",
203-
{},
204-
"TARGETING_MATCH",
205-
"target_variant",
206-
None,
207-
),
208198
],
209199
ids=[
210200
"static_flag",
@@ -215,7 +205,6 @@ def test_resolve_boolean_details_invalid_variant(resolver, flag):
215205
"boolean_falsy_target",
216206
"integer_falsy_target",
217207
"object_falsy_target",
218-
"none_target_value",
219208
],
220209
)
221210
def test_resolver_details(

0 commit comments

Comments
 (0)