Skip to content

Commit 875c1b9

Browse files
committed
fix(flagd): handle "None" target value correctly
1 parent ab61ae6 commit 875c1b9

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/in_process.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,6 @@ def _resolve(
121121
)
122122

123123
variant, value = flag.get_variant(variant)
124-
if value is None:
125-
raise ParseError(f"Resolved variant {variant} not in variants config.")
126124

127125
return FlagResolutionDetails(
128126
value,

providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/flags.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,4 +92,7 @@ def get_variant(
9292
if isinstance(variant_key, bool):
9393
variant_key = str(variant_key).lower()
9494

95+
if variant_key not in self.variants:
96+
raise ParseError(f"Resolved variant {variant_key} not in variants config.")
97+
9598
return variant_key, self.variants.get(variant_key)

providers/openfeature-provider-flagd/tests/test_in_process.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,11 @@ def test_resolve_boolean_details_invalid_variant(resolver, flag):
143143
context("target_variant"), "resolve_object_details", {},
144144
"TARGETING_MATCH", "target_variant", {},
145145
),
146+
(
147+
{"default_variant": None, "target_variant": None}, targeting(),
148+
context("target_variant"), "resolve_object_details", {},
149+
"TARGETING_MATCH", "target_variant", None,
150+
),
146151
],
147152
ids=[
148153
"static_flag",
@@ -153,6 +158,7 @@ def test_resolve_boolean_details_invalid_variant(resolver, flag):
153158
"boolean_falsy_target",
154159
"integer_falsy_target",
155160
"object_falsy_target",
161+
"none_target_value",
156162
],
157163
)
158164
def test_resolver_details(

0 commit comments

Comments
 (0)