Skip to content

Commit dceff15

Browse files
committed
fixup: naming
Signed-off-by: Simon Schrottner <[email protected]>
1 parent 994697d commit dceff15

File tree

3 files changed

+13
-6
lines changed

3 files changed

+13
-6
lines changed

providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/provider.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ def setup_resolver(self) -> AbstractResolver:
125125
):
126126
return InProcessResolver(
127127
self.config,
128-
self.on_provider_ready,
128+
self.emit_provider_ready_with_context,
129129
self.emit_provider_error,
130130
self.emit_provider_stale,
131131
self.emit_provider_configuration_changed,
@@ -195,8 +195,9 @@ def resolve_object_details(
195195
return self.resolver.resolve_object_details(
196196
key, default_value, evaluation_context
197197
)
198-
199-
def on_provider_ready(self, details: ProviderEventDetails, metadata: dict) -> None:
200-
self.enriched_context = metadata
198+
def emit_provider_ready_with_context(
199+
self, details: ProviderEventDetails, context: dict
200+
) -> None:
201+
self.enriched_context = context
201202
self.emit_provider_ready(details)
202203
pass

providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/grpc.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,10 @@ def monitor(self) -> None:
137137

138138
def _state_change_callback(self, new_state: ChannelConnectivity) -> None:
139139
logger.debug(f"gRPC state change: {new_state}")
140-
if new_state == ChannelConnectivity.READY:
140+
if (
141+
new_state == grpc.ChannelConnectivity.READY
142+
or new_state == grpc.ChannelConnectivity.IDLE
143+
):
141144
if not self.thread or not self.thread.is_alive():
142145
self.thread = threading.Thread(
143146
target=self.listen,

providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/connector/grpc_watcher.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,10 @@ def monitor(self) -> None:
107107

108108
def _state_change_callback(self, new_state: grpc.ChannelConnectivity) -> None:
109109
logger.debug(f"gRPC state change: {new_state}")
110-
if new_state == grpc.ChannelConnectivity.READY:
110+
if (
111+
new_state == grpc.ChannelConnectivity.READY
112+
or new_state == grpc.ChannelConnectivity.IDLE
113+
):
111114
if not self.thread or not self.thread.is_alive():
112115
self.thread = threading.Thread(
113116
target=self.listen,

0 commit comments

Comments
 (0)