fix(instrumentation-knex): Support better-sqlite3 errors (#2650)

Co-authored-by: Abhijeet Prasad <[email protected]>

Author: deejay1

package-lock.json

@@ -48,7 +48,8 @@
     "@opentelemetry/sdk-trace-node": "^1.8.0",
     "@types/mocha": "7.0.2",
     "@types/node": "18.18.14",
-    "knex": "0.95.9",
+    "better-sqlite3": "11.0.0",
+    "knex": "3.1.0",
     "nyc": "15.1.0",
     "rimraf": "5.0.10",
     "sqlite3": "5.1.7",

plugins/node/opentelemetry-instrumentation-knex/package.json

@@ -185,8 +185,8 @@ export class KnexInstrumentation extends InstrumentationBase<KnexInstrumentation
             const formatter = utils.getFormatter(this);
             const fullQuery = formatter(query.sql, query.bindings || []);
             const message = err.message.replace(fullQuery + ' - ', '');
-            const clonedError = utils.cloneErrorWithNewMessage(err, message);
-            span.recordException(clonedError);
+            const exc = utils.otelExceptionFromKnexError(err, message);
+            span.recordException(exc);
             span.setStatus({ code: api.SpanStatusCode.ERROR, message });
             span.end();
             throw err;