feature: now we allow use the raw request cosocket returned by ngx.req.socket(true) to send the raw HTTP response header. thanks aviramc for requesting this in #242. also we now always enable "lingering close" in the nginx core when raw req sockets are used.

Author: agentzh

src/ngx_http_lua_socket_tcp.c

@@ -3168,9 +3168,9 @@ ngx_http_lua_req_socket(lua_State *L)
         }
 
         if (!r->header_sent) {
-            lua_pushnil(L);
-            lua_pushliteral(L, "response header not sent yet");
-            return 2;
+            /* prevent other parts of nginx from sending out
+             * the response header */
+            r->header_sent = 1;
         }
 
         dd("ctx acquired raw req socket: %d", ctx->acquired_raw_req_socket);
@@ -3212,6 +3212,7 @@ ngx_http_lua_req_socket(lua_State *L)
 
         ctx->acquired_raw_req_socket = 1;
         r->keepalive = 0;
+        r->lingering_close = 1;
 #endif
 
     } else {

t/116-raw-req-socket.t

@@ -5,7 +5,7 @@ use t::TestNginxLua;
 
 repeat_each(2);
 
-plan tests => repeat_each() * 26;
+plan tests => repeat_each() * 29;
 
 our $HtmlDir = html_dir;
 
@@ -119,18 +119,26 @@ lua raw req socket tcp_nodelay
                 ngx.log(ngx.ERR, "server: failed to get raw req socket: ", err)
                 return
             end
+            local ok, err = sock:send("HTTP/1.1 200 OK\\r\\nContent-Length: 5\\r\\n\\r\\nhello")
+            if not ok then
+                ngx.log(ngx.ERR, "failed to send: ", err)
+                return
+            end
         ';
     }
 
 --- raw_request eval
 "GET /t HTTP/1.0\r
 Host: localhost\r
-Upgrade: mysocket\r
+Content-Length: 5\r
 \r
 hello"
---- ignore_response
---- error_log
-server: failed to get raw req socket: response header not sent yet
+--- response_headers
+Content-Length: 5
+--- response_body chop
+hello
+--- no_error_log
+[error]
 
 
 
@@ -144,7 +152,7 @@ server: failed to get raw req socket: response header not sent yet
             local sock, err = ngx.req.socket(true)
             if not sock then
                 ngx.log(ngx.ERR, "server: failed to get raw req socket: ", err)
-                return
+                return ngx.exit(500)
             end
         ';
     }