#patch: #146 allow updateSnapshot=false for legacy compatibility

jackmatt2 · jackmatt2 · commit 04758283fbad · 2023-02-16T20:00:38.000+11:00
diff --git a/java-snapshot-testing-core/src/main/java/au/com/origin/snapshots/config/PropertyResolvingSnapshotConfig.java b/java-snapshot-testing-core/src/main/java/au/com/origin/snapshots/config/PropertyResolvingSnapshotConfig.java
@@ -39,7 +39,7 @@ public Optional<String> updateSnapshot() {
       String updateSnapshot = SnapshotProperties.getOrThrow("update-snapshot");
       if ("all".equals(updateSnapshot)) {
         return Optional.of("");
-      } else if ("none".equals(updateSnapshot)) {
+      } else if ("none".equals(updateSnapshot) || "false".equals(updateSnapshot)) {
         return Optional.empty();
       }
       return Optional.of(updateSnapshot);

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public Optional<String> updateSnapshot() {`
`39`	`39`	`String updateSnapshot = SnapshotProperties.getOrThrow("update-snapshot");`
`40`	`40`	`if ("all".equals(updateSnapshot)) {`
`41`	`41`	`return Optional.of("");`
`42`		`- } else if ("none".equals(updateSnapshot)) {`
	`42`	`+ } else if ("none".equals(updateSnapshot) \|\| "false".equals(updateSnapshot)) {`
`43`	`43`	`return Optional.empty();`
`44`	`44`	`}`
`45`	`45`	`return Optional.of(updateSnapshot);`