Skip to content

Commit 7e5ca9d

Browse files
committed
added notes
1 parent 30bb8e7 commit 7e5ca9d

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

.github/workflows/npmPublish.yml

+5
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ on:
55
branches:
66
- main
77

8+
# These currently require that the package version has been manually updated
9+
# We could potentially automate it by creating a separate script that fetches the current version on npm and compares it the the version in the package.json. If it matches, it auto-increments the number in package.json (ie from 2.1.11 to 2.1.12). And we run this script before the publish step.
10+
# Simpler solution is to use npm version command that can be used to increment the version number (npm version patch, npm version minor, npm version major) where format is major.minor.patch
11+
# Any version incrementing should probably happen on pushes to dev so that dev and main branch stay in sync. We can simply always increment the patch version
12+
# Think we can update github settings to ensure you merges fail if an action fails, but that means each merge updates all 3 packages
813
jobs:
914
publish-react:
1015
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)