Skip to content

Commit 1b87167

Browse files
committed
Add implicit reads for FlowState sinks and steps
1 parent d5f101d commit 1b87167

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
category: fix
3+
---
4+
* Fixed an issue in the taint tracking analysis where implicit reads were not allowed by default in sinks or additional taint steps that used flow states.

java/ql/lib/semmle/code/java/dataflow/internal/tainttracking1/TaintTrackingImpl.qll

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,12 @@ abstract class Configuration extends DataFlow::Configuration {
172172
}
173173

174174
override predicate allowImplicitRead(DataFlow::Node node, DataFlow::ContentSet c) {
175-
(this.isSink(node) or this.isAdditionalTaintStep(node, _)) and
175+
(
176+
this.isSink(node) or
177+
this.isSink(node, _) or
178+
this.isAdditionalTaintStep(node, _) or
179+
this.isAdditionalTaintStep(node, _, _, _)
180+
) and
176181
defaultImplicitTaintRead(node, c)
177182
}
178183

0 commit comments

Comments
 (0)