Skip to content

Commit e0f0fe1

Browse files
authored
Changed SeriesGroupBy to return Series (#445)
* update * updated the generic.pyi
1 parent 3d1eee4 commit e0f0fe1

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

pandas-stubs/core/groupby/generic.pyi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,12 @@ class SeriesGroupBy(GroupBy, Generic[S1]):
6767
def describe(self, **kwargs) -> DataFrame: ...
6868
def value_counts(
6969
self,
70-
normalize: bool = ...,
70+
normalize: Literal[False, True] = ...,
7171
sort: bool = ...,
7272
ascending: bool = ...,
7373
bins=...,
7474
dropna: bool = ...,
75-
) -> DataFrame: ...
75+
) -> Series: ...
7676
def count(self) -> Series[int]: ...
7777
def pct_change(
7878
self,

tests/test_frame.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1942,3 +1942,14 @@ def series_added_in_astype() -> None:
19421942
# GH410
19431943
df = pd.DataFrame({"a": [1, 2, 3], "b": [4, 5, 6]})
19441944
check(assert_type(df.astype(df.dtypes), pd.DataFrame), pd.DataFrame)
1945+
1946+
1947+
def test_series_groupby_and_value_counts() -> None:
1948+
df = pd.DataFrame(
1949+
{
1950+
"Animal": ["Falcon", "Falcon", "Parrot", "Parrot"],
1951+
"Max Speed": [380, 370, 24, 26],
1952+
}
1953+
)
1954+
c: pd.Series = df.groupby("Animal")["Max Speed"].value_counts()
1955+
check(assert_type(c, pd.Series), pd.Series)

0 commit comments

Comments
 (0)