Skip to content

Commit f780a14

Browse files
authored
Revert "gh:552 - Corrected Series.mean return type" (#647)
Revert "gh:552 - Corrected Series.mean return type (#622)" This reverts commit c03e23c.
1 parent 492e9bd commit f780a14

File tree

6 files changed

+12
-14
lines changed

6 files changed

+12
-14
lines changed

pandas-stubs/_typing.pyi

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -286,8 +286,6 @@ IndexIterScalar: TypeAlias = (
286286
| float
287287
| Timestamp
288288
| Timedelta
289-
| np.integer
290-
| np.float_
291289
)
292290
Scalar: TypeAlias = IndexIterScalar | complex
293291
ScalarT = TypeVar("ScalarT", bound=Scalar)

pandas-stubs/core/series.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1609,7 +1609,7 @@ class Series(IndexOpsMixin, NDFrame, Generic[S1]):
16091609
level: None = ...,
16101610
numeric_only: _bool = ...,
16111611
**kwargs,
1612-
) -> np.float64: ...
1612+
) -> float: ...
16131613
def median(
16141614
self,
16151615
axis: AxisIndex | None = ...,

tests/test_frame.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2019,12 +2019,12 @@ def test_groupby_apply() -> None:
20192019
# GH 167
20202020
df = pd.DataFrame({"col1": [1, 2, 3], "col2": [4, 5, 6]})
20212021

2022-
def sum_mean(x: pd.DataFrame) -> np.float64:
2022+
def sum_mean(x: pd.DataFrame) -> float:
20232023
return x.sum().mean()
20242024

20252025
check(assert_type(df.groupby("col1").apply(sum_mean), pd.Series), pd.Series)
20262026

2027-
lfunc: Callable[[pd.DataFrame], np.float64] = lambda x: x.sum().mean()
2027+
lfunc: Callable[[pd.DataFrame], float] = lambda x: x.sum().mean()
20282028
check(
20292029
assert_type(df.groupby("col1").apply(lfunc), pd.Series),
20302030
pd.Series,

tests/test_resampler.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ def g(val: DataFrame) -> Series:
155155

156156
check(assert_type(DF.resample("m").pipe(g), DataFrame), DataFrame)
157157

158-
def h(val: DataFrame) -> np.float64:
158+
def h(val: DataFrame) -> float:
159159
return val.mean().mean()
160160

161161
check(assert_type(DF.resample("m").pipe(h), Series), Series)
@@ -245,10 +245,10 @@ def test_aggregate_series() -> None:
245245
DataFrame,
246246
)
247247

248-
def f(val: Series) -> np.float64:
248+
def f(val: Series) -> float:
249249
return val.mean()
250250

251-
check(assert_type(S.resample("m").aggregate(f), _AggRetType), pd.Series)
251+
check(assert_type(S.resample("m").aggregate(f), _AggRetType), Series)
252252

253253

254254
def test_asfreq_series() -> None:

tests/test_series.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -306,10 +306,10 @@ def test_types_rank() -> None:
306306

307307
def test_types_mean() -> None:
308308
s = pd.Series([1, 2, 3, np.nan])
309-
check(assert_type(s.mean(), np.float64), np.float64)
309+
f1: float = s.mean()
310310
s1: pd.Series = s.groupby(level=0).mean()
311-
f2: np.float64 = s.mean(skipna=False)
312-
f3: np.float64 = s.mean(numeric_only=False)
311+
f2: float = s.mean(skipna=False)
312+
f3: float = s.mean(numeric_only=False)
313313

314314

315315
def test_types_median() -> None:

tests/test_windowing.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ def test_rolling_basic_math_series() -> None:
148148
def test_rolling_apply_series() -> None:
149149
check(assert_type(S.rolling(10).apply(np.mean), Series), Series)
150150

151-
def _mean(df: Series) -> np.float64:
151+
def _mean(df: Series) -> float:
152152
return df.mean()
153153

154154
check(assert_type(S.rolling(10).apply(_mean), Series), Series)
@@ -163,7 +163,7 @@ def test_rolling_aggregate_series() -> None:
163163
check(assert_type(S.rolling(10).aggregate(np.mean), Series), Series)
164164
check(assert_type(S.rolling(10).aggregate("mean"), Series), Series)
165165

166-
def _mean(s: Series) -> np.float64:
166+
def _mean(s: Series) -> float:
167167
return s.mean()
168168

169169
check(assert_type(S.rolling(10).aggregate(_mean), Series), Series)
@@ -256,7 +256,7 @@ def test_expanding_basic_math_series() -> None:
256256
def test_expanding_apply_series() -> None:
257257
check(assert_type(S.expanding(10).apply(np.mean), Series), Series)
258258

259-
def _mean(df: Series) -> np.float64:
259+
def _mean(df: Series) -> float:
260260
return df.mean()
261261

262262
check(assert_type(S.expanding(10).apply(_mean), Series), Series)

0 commit comments

Comments
 (0)