Change after 1st review

Author: makbigc

doc/source/whatsnew/v0.25.0.rst

@@ -99,7 +99,7 @@ Other Enhancements
 - Error message for missing required imports now includes the original import error's text (:issue:`23868`)
 - :class:`DatetimeIndex` and :class:`TimedeltaIndex` now have a ``mean`` method (:issue:`24757`)
 - :meth:`DataFrame.describe` now formats integer percentiles without decimal point (:issue:`26660`)
-- :meth:`nargsort` handles ``ExtensionArray`` with its ``_values_for_argsort`` method (:issue:`25439`)
+- :meth:`nargsort` handles ``ExtensionArray`` without calling ``np.asanyarray`` (:issue:`25439`)
 
 .. _whatsnew_0250.api_breaking:
 

pandas/tests/extension/base/methods.py

@@ -2,6 +2,7 @@
 import pytest
 
 import pandas as pd
+from pandas.core.sorting import nargsort
 import pandas.util.testing as tm
 
 from .base import BaseExtensionTests
@@ -49,9 +50,9 @@ def test_argsort_missing(self, data_missing_for_sorting):
         ('first', np.array([1, 2, 0]))
     ])
     def test_nargsort(self, data_missing_for_sorting, na_position, expected):
-        from pandas.core.sorting import nargsort
+        # GH 25439
         result = nargsort(data_missing_for_sorting, na_position=na_position)
-        tm.assert_numpy_array_equal(result, expected)
+        tm.assert_numpy_array_equal(result, expected, check_dtype=False)
 
     @pytest.mark.parametrize('ascending', [True, False])
     def test_sort_values(self, data_for_sorting, ascending):

pandas/tests/test_sorting.py

@@ -6,8 +6,7 @@
 from numpy import nan
 import pytest
 
-from pandas import (
-    DataFrame, MultiIndex, Series, array, concat, merge, to_datetime)
+from pandas import DataFrame, MultiIndex, Series, array, concat, merge
 from pandas.core import common as com
 from pandas.core.sorting import (
     decons_group_index, get_group_index, is_int64_overflow_possible,