Skip to content

Commit 0a7a362

Browse files
committed
More proper oop
1 parent 4f8b133 commit 0a7a362

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

pandas/tests/series/test_api.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,8 @@
2323
class SharedWithSparse(object):
2424

2525
def _assert_series_equal(self, left, right):
26-
"""Helper dispatching to series class dependent assertion"""
27-
if isinstance(left, SparseSeries) or isinstance(right, SparseSeries):
28-
return tm.assert_sp_series_equal(left, right)
29-
return tm.assert_series_equal(left, right)
26+
"""Dispatch to series class dependent assertion"""
27+
raise NotImplementedError
3028

3129
def test_scalarop_preserve_name(self):
3230
result = self.ts * 2
@@ -196,6 +194,7 @@ def test_constructor_dict_timedelta_index(self):
196194
class TestSeriesMisc(TestData, SharedWithSparse):
197195

198196
series_klass = Series
197+
_assert_series_equal = staticmethod(tm.assert_series_equal)
199198

200199
def test_tab_completion(self):
201200
# GH 9910

pandas/tests/sparse/test_series.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ def _test_data2_zero():
6161
class TestSparseSeries(SharedWithSparse):
6262

6363
series_klass = SparseSeries
64+
_assert_series_equal = staticmethod(tm.assert_sp_series_equal)
6465

6566
def setup_method(self, method):
6667
arr, index = _test_data1()

0 commit comments

Comments
 (0)