Docs

Author: TomAugspurger

pandas/core/arrays/base.py

@@ -204,6 +204,25 @@ def isna(self):
         """
         raise AbstractMethodError(self)
 
+    def value_counts(self, dropna=True):
+        """Compute a histogram of the counts of non-null values.
+
+        Parameters
+        ----------
+        dropna : bool, default True
+            Don't include counts of NaN
+
+        Returns
+        -------
+        value_counts : Series
+        """
+        from pandas import value_counts
+
+        if dropna:
+            self = self[~self.isna()]
+
+        return value_counts(np.array(self))
+
     # ------------------------------------------------------------------------
     # Indexing methods
     # ------------------------------------------------------------------------
@@ -235,9 +254,8 @@ def take(self, indexer, allow_fill=True, fill_value=None):
 
         Examples
         --------
-        Suppose the extension array somehow backed by a NumPy array and that
-        the underlying structured array is stored as ``self.data``. Then
-        ``take`` may be written as
+        Suppose the extension array is backed by a NumPy array stored as
+        ``self.data``. Then ``take`` may be written as
 
         .. code-block:: python
 
@@ -246,6 +264,10 @@ def take(self, indexer, allow_fill=True, fill_value=None):
                result = self.data.take(indexer)
                result[mask] = self._fill_value
                return type(self)(result)
+
+        See Also
+        --------
+        numpy.take
         """
         raise AbstractMethodError(self)
 
@@ -305,14 +327,6 @@ def _can_hold_na(self):
         """
         return True
 
-    def value_counts(self, dropna=True):
-        from pandas import value_counts
-
-        if dropna:
-            self = self[~self.isna()]
-
-        return value_counts(np.array(self))
-
     @property
     def _ndarray_values(self):
         # type: () -> np.ndarray

pandas/core/indexing.py

@@ -618,9 +618,9 @@ def can_do_equal_len():
                     return
 
             if isinstance(value, (ABCSeries, dict)):
-                # TODO: ExtensionBlock.setitem this causes issues with setting
-                # for extensionarrays that store dicts. Need to decide if it's
-                # worth supporting that or now
+                # TODO(EA): ExtensionBlock.setitem this causes issues with
+                # setting for extensionarrays that store dicts. Need to decide
+                # if it's worth supporting that.
                 value = self._align_series(indexer, Series(value))
 
             elif isinstance(value, ABCDataFrame):