Skip to content

Commit 1d530e4

Browse files
authored
BUG: Fix skipna default value in method signatures (#43980)
1 parent ba6b4eb commit 1d530e4

File tree

1 file changed

+25
-31
lines changed

1 file changed

+25
-31
lines changed

pandas/core/generic.py

Lines changed: 25 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -10345,15 +10345,13 @@ def _stat_function_ddof(
1034510345
name: str,
1034610346
func,
1034710347
axis=None,
10348-
skipna=None,
10348+
skipna=True,
1034910349
level=None,
1035010350
ddof=1,
1035110351
numeric_only=None,
1035210352
**kwargs,
1035310353
):
1035410354
nv.validate_stat_ddof_func((), kwargs, fname=name)
10355-
if skipna is None:
10356-
skipna = True
1035710355
if axis is None:
1035810356
axis = self._stat_axis_number
1035910357
if level is not None:
@@ -10372,21 +10370,21 @@ def _stat_function_ddof(
1037210370
)
1037310371

1037410372
def sem(
10375-
self, axis=None, skipna=None, level=None, ddof=1, numeric_only=None, **kwargs
10373+
self, axis=None, skipna=True, level=None, ddof=1, numeric_only=None, **kwargs
1037610374
):
1037710375
return self._stat_function_ddof(
1037810376
"sem", nanops.nansem, axis, skipna, level, ddof, numeric_only, **kwargs
1037910377
)
1038010378

1038110379
def var(
10382-
self, axis=None, skipna=None, level=None, ddof=1, numeric_only=None, **kwargs
10380+
self, axis=None, skipna=True, level=None, ddof=1, numeric_only=None, **kwargs
1038310381
):
1038410382
return self._stat_function_ddof(
1038510383
"var", nanops.nanvar, axis, skipna, level, ddof, numeric_only, **kwargs
1038610384
)
1038710385

1038810386
def std(
10389-
self, axis=None, skipna=None, level=None, ddof=1, numeric_only=None, **kwargs
10387+
self, axis=None, skipna=True, level=None, ddof=1, numeric_only=None, **kwargs
1039010388
):
1039110389
return self._stat_function_ddof(
1039210390
"std", nanops.nanstd, axis, skipna, level, ddof, numeric_only, **kwargs
@@ -10398,7 +10396,7 @@ def _stat_function(
1039810396
name: str,
1039910397
func,
1040010398
axis=None,
10401-
skipna=None,
10399+
skipna=True,
1040210400
level=None,
1040310401
numeric_only=None,
1040410402
**kwargs,
@@ -10407,8 +10405,6 @@ def _stat_function(
1040710405
nv.validate_median((), kwargs)
1040810406
else:
1040910407
nv.validate_stat_func((), kwargs, fname=name)
10410-
if skipna is None:
10411-
skipna = True
1041210408
if axis is None:
1041310409
axis = self._stat_axis_number
1041410410
if level is not None:
@@ -10426,32 +10422,32 @@ def _stat_function(
1042610422
func, name=name, axis=axis, skipna=skipna, numeric_only=numeric_only
1042710423
)
1042810424

10429-
def min(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10425+
def min(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1043010426
return self._stat_function(
1043110427
"min", nanops.nanmin, axis, skipna, level, numeric_only, **kwargs
1043210428
)
1043310429

10434-
def max(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10430+
def max(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1043510431
return self._stat_function(
1043610432
"max", nanops.nanmax, axis, skipna, level, numeric_only, **kwargs
1043710433
)
1043810434

10439-
def mean(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10435+
def mean(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1044010436
return self._stat_function(
1044110437
"mean", nanops.nanmean, axis, skipna, level, numeric_only, **kwargs
1044210438
)
1044310439

10444-
def median(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10440+
def median(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1044510441
return self._stat_function(
1044610442
"median", nanops.nanmedian, axis, skipna, level, numeric_only, **kwargs
1044710443
)
1044810444

10449-
def skew(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10445+
def skew(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1045010446
return self._stat_function(
1045110447
"skew", nanops.nanskew, axis, skipna, level, numeric_only, **kwargs
1045210448
)
1045310449

10454-
def kurt(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10450+
def kurt(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1045510451
return self._stat_function(
1045610452
"kurt", nanops.nankurt, axis, skipna, level, numeric_only, **kwargs
1045710453
)
@@ -10464,7 +10460,7 @@ def _min_count_stat_function(
1046410460
name: str,
1046510461
func,
1046610462
axis=None,
10467-
skipna=None,
10463+
skipna=True,
1046810464
level=None,
1046910465
numeric_only=None,
1047010466
min_count=0,
@@ -10476,8 +10472,6 @@ def _min_count_stat_function(
1047610472
nv.validate_prod((), kwargs)
1047710473
else:
1047810474
nv.validate_stat_func((), kwargs, fname=name)
10479-
if skipna is None:
10480-
skipna = True
1048110475
if axis is None:
1048210476
axis = self._stat_axis_number
1048310477
if level is not None:
@@ -10508,7 +10502,7 @@ def _min_count_stat_function(
1050810502
def sum(
1050910503
self,
1051010504
axis=None,
10511-
skipna=None,
10505+
skipna=True,
1051210506
level=None,
1051310507
numeric_only=None,
1051410508
min_count=0,
@@ -10521,7 +10515,7 @@ def sum(
1052110515
def prod(
1052210516
self,
1052310517
axis=None,
10524-
skipna=None,
10518+
skipna=True,
1052510519
level=None,
1052610520
numeric_only=None,
1052710521
min_count=0,
@@ -10648,7 +10642,7 @@ def mad(self, axis=None, skipna=None, level=None):
1064810642
def sem(
1064910643
self,
1065010644
axis=None,
10651-
skipna=None,
10645+
skipna=True,
1065210646
level=None,
1065310647
ddof=1,
1065410648
numeric_only=None,
@@ -10670,7 +10664,7 @@ def sem(
1067010664
def var(
1067110665
self,
1067210666
axis=None,
10673-
skipna=None,
10667+
skipna=True,
1067410668
level=None,
1067510669
ddof=1,
1067610670
numeric_only=None,
@@ -10693,7 +10687,7 @@ def var(
1069310687
def std(
1069410688
self,
1069510689
axis=None,
10696-
skipna=None,
10690+
skipna=True,
1069710691
level=None,
1069810692
ddof=1,
1069910693
numeric_only=None,
@@ -10773,7 +10767,7 @@ def cumprod(self, axis=None, skipna=True, *args, **kwargs):
1077310767
def sum(
1077410768
self,
1077510769
axis=None,
10776-
skipna=None,
10770+
skipna=True,
1077710771
level=None,
1077810772
numeric_only=None,
1077910773
min_count=0,
@@ -10798,7 +10792,7 @@ def sum(
1079810792
def prod(
1079910793
self,
1080010794
axis=None,
10801-
skipna=None,
10795+
skipna=True,
1080210796
level=None,
1080310797
numeric_only=None,
1080410798
min_count=0,
@@ -10821,7 +10815,7 @@ def prod(
1082110815
see_also="",
1082210816
examples="",
1082310817
)
10824-
def mean(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10818+
def mean(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1082510819
return NDFrame.mean(self, axis, skipna, level, numeric_only, **kwargs)
1082610820

1082710821
setattr(cls, "mean", mean)
@@ -10836,7 +10830,7 @@ def mean(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
1083610830
see_also="",
1083710831
examples="",
1083810832
)
10839-
def skew(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10833+
def skew(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1084010834
return NDFrame.skew(self, axis, skipna, level, numeric_only, **kwargs)
1084110835

1084210836
setattr(cls, "skew", skew)
@@ -10854,7 +10848,7 @@ def skew(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
1085410848
see_also="",
1085510849
examples="",
1085610850
)
10857-
def kurt(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10851+
def kurt(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1085810852
return NDFrame.kurt(self, axis, skipna, level, numeric_only, **kwargs)
1085910853

1086010854
setattr(cls, "kurt", kurt)
@@ -10871,7 +10865,7 @@ def kurt(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
1087110865
examples="",
1087210866
)
1087310867
def median(
10874-
self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs
10868+
self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs
1087510869
):
1087610870
return NDFrame.median(self, axis, skipna, level, numeric_only, **kwargs)
1087710871

@@ -10889,7 +10883,7 @@ def median(
1088910883
see_also=_stat_func_see_also,
1089010884
examples=_max_examples,
1089110885
)
10892-
def max(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10886+
def max(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1089310887
return NDFrame.max(self, axis, skipna, level, numeric_only, **kwargs)
1089410888

1089510889
setattr(cls, "max", max)
@@ -10906,7 +10900,7 @@ def max(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
1090610900
see_also=_stat_func_see_also,
1090710901
examples=_min_examples,
1090810902
)
10909-
def min(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10903+
def min(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1091010904
return NDFrame.min(self, axis, skipna, level, numeric_only, **kwargs)
1091110905

1091210906
setattr(cls, "min", min)

0 commit comments

Comments
 (0)