Skip to content

Commit 3382e12

Browse files
lewisacidicjreback
authored andcommitted
BUG: Series.from_csv not loading header names, #10483
1 parent 5a76b44 commit 3382e12

File tree

3 files changed

+14
-1
lines changed

3 files changed

+14
-1
lines changed

doc/source/whatsnew/v0.17.0.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,3 +138,5 @@ Bug Fixes
138138
- Bug in ``read_msgpack`` where input type is not always checked (:issue:`10369`)
139139

140140
- Bug in `pandas.read_csv` with ``index_col=False`` or with ``index_col=['a', 'b']`` (:issue:`10413`, :issue:`10467`)
141+
142+
- Bug in `Series.from_csv` with ``header`` kwarg not setting the ``Series.name`` or the ``Series.index.name`` (:issue:`10483`)

pandas/core/series.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2330,7 +2330,9 @@ def from_csv(cls, path, sep=',', parse_dates=True, header=None,
23302330
encoding=encoding,
23312331
infer_datetime_format=infer_datetime_format)
23322332
result = df.icol(0)
2333-
result.index.name = result.name = None
2333+
if header is None:
2334+
result.index.name = result.name = None
2335+
23342336
return result
23352337

23362338
def to_csv(self, path, index=True, sep=",", na_rep='',

pandas/tests/test_series.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4979,6 +4979,11 @@ def test_from_csv(self):
49794979
self.assertTrue(ts.name is None)
49804980
self.assertTrue(ts.index.name is None)
49814981

4982+
# GH10483
4983+
self.ts.to_csv(path, header=True)
4984+
ts_h = Series.from_csv(path, header=0)
4985+
self.assertTrue(ts_h.name == 'ts')
4986+
49824987
self.series.to_csv(path)
49834988
series = Series.from_csv(path)
49844989
self.assertIsNone(series.name)
@@ -4987,6 +4992,10 @@ def test_from_csv(self):
49874992
self.assertTrue(series.name is None)
49884993
self.assertTrue(series.index.name is None)
49894994

4995+
self.series.to_csv(path, header=True)
4996+
series_h = Series.from_csv(path, header=0)
4997+
self.assertTrue(series_h.name == 'series')
4998+
49904999
outfile = open(path, 'w')
49915000
outfile.write('1998-01-01|1.0\n1999-01-01|2.0')
49925001
outfile.close()

0 commit comments

Comments
 (0)