Skip to content

Commit 37bd4b4

Browse files
committed
DEPR: move NumericIndex._convert_tolerance to Index
1 parent 79b2610 commit 37bd4b4

File tree

2 files changed

+11
-16
lines changed

2 files changed

+11
-16
lines changed

pandas/core/indexes/base.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3780,6 +3780,17 @@ def _convert_tolerance(self, tolerance, target: np.ndarray | Index) -> np.ndarra
37803780
tolerance = np.asarray(tolerance)
37813781
if target.size != tolerance.size and tolerance.size > 1:
37823782
raise ValueError("list-like tolerance size must match target index size")
3783+
elif is_numeric_dtype(self) and not np.issubdtype(tolerance.dtype, np.number):
3784+
if tolerance.ndim > 0:
3785+
raise ValueError(
3786+
f"tolerance argument for {type(self).__name__} must contain "
3787+
"numeric elements if it is list type"
3788+
)
3789+
3790+
raise ValueError(
3791+
f"tolerance argument for {type(self).__name__} must be numeric "
3792+
f"if it is a scalar: {repr(tolerance)}"
3793+
)
37833794
return tolerance
37843795

37853796
@final

pandas/core/indexes/numeric.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -221,22 +221,6 @@ def _maybe_cast_slice_bound(self, label, side: str):
221221

222222
# ----------------------------------------------------------------
223223

224-
def _convert_tolerance(self, tolerance, target):
225-
tolerance = super()._convert_tolerance(tolerance, target)
226-
227-
if not np.issubdtype(tolerance.dtype, np.number):
228-
if tolerance.ndim > 0:
229-
raise ValueError(
230-
f"tolerance argument for {type(self).__name__} must contain "
231-
"numeric elements if it is list type"
232-
)
233-
234-
raise ValueError(
235-
f"tolerance argument for {type(self).__name__} must be numeric "
236-
f"if it is a scalar: {repr(tolerance)}"
237-
)
238-
return tolerance
239-
240224
@classmethod
241225
def _assert_safe_casting(cls, data: np.ndarray, subarr: np.ndarray) -> None:
242226
"""

0 commit comments

Comments
 (0)