Skip to content

Commit 457a265

Browse files
committed
address review
1 parent 6a98496 commit 457a265

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

doc/source/whatsnew/v0.23.0.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -716,7 +716,7 @@ Datetimelike
716716
- Bug in :class:`Timestamp` and :func:`to_datetime` where a string representing a barely out-of-bounds timestamp would be incorrectly rounded down instead of raising ``OutOfBoundsDatetime`` (:issue:`19382`)
717717
- Bug in :func:`Timestamp.floor` :func:`DatetimeIndex.floor` where time stamps far in the future and past were not rounded correctly (:issue:`19206`)
718718
- Bug in :func:`to_datetime` where passing an out-of-bounds datetime with ``errors='coerce'`` and ``utc=True`` would raise ``OutOfBoundsDatetime`` instead of parsing to ``NaT`` (:issue:`19612`)
719-
- Bug in :class:`Timedelta`: where a numerical value with a unit would round values (:issue: `12690`)
719+
- Bug in :class:`Timedelta` where a numerical value with a unit would incur round errors (:issue:`12690`)
720720
-
721721

722722
Timezones

pandas/tests/scalar/test_timedelta.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ def test_rounding_on_int_unit_construction(self, unit, value, expected):
440440
result = Timedelta(value, unit=unit)
441441
assert result.value == expected
442442
result = Timedelta(str(value) + unit)
443-
assert result.value
443+
assert result.value == expected
444444

445445
def test_overflow_on_construction(self):
446446
# xref https://github.com/statsmodels/statsmodels/issues/3374

0 commit comments

Comments
 (0)