Skip to content

Commit 604fffb

Browse files
authored
CLN: remove extraneous arg from get_block_type (#43607)
1 parent 0a35903 commit 604fffb

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

pandas/core/internals/api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def make_block(
5252

5353
if klass is None:
5454
dtype = dtype or values.dtype
55-
klass = get_block_type(values, dtype)
55+
klass = get_block_type(dtype)
5656

5757
elif klass is DatetimeTZBlock and not is_datetime64tz_dtype(values.dtype):
5858
# pyarrow calls get here

pandas/core/internals/blocks.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1918,13 +1918,12 @@ def maybe_coerce_values(values: ArrayLike) -> ArrayLike:
19181918
return values
19191919

19201920

1921-
def get_block_type(values, dtype: DtypeObj | None = None):
1921+
def get_block_type(dtype: DtypeObj):
19221922
"""
19231923
Find the appropriate Block subclass to use for the given values and dtype.
19241924
19251925
Parameters
19261926
----------
1927-
values : ndarray-like
19281927
dtype : numpy or pandas dtype
19291928
19301929
Returns
@@ -1933,9 +1932,6 @@ def get_block_type(values, dtype: DtypeObj | None = None):
19331932
"""
19341933
# We use vtype and kind checks because they are much more performant
19351934
# than is_foo_dtype
1936-
if dtype is None:
1937-
dtype = values.dtype
1938-
19391935
vtype = dtype.type
19401936
kind = dtype.kind
19411937

@@ -1970,7 +1966,7 @@ def new_block(values, placement, *, ndim: int, klass=None) -> Block:
19701966
check_ndim(values, placement, ndim)
19711967

19721968
if klass is None:
1973-
klass = get_block_type(values, values.dtype)
1969+
klass = get_block_type(values.dtype)
19741970

19751971
values = maybe_coerce_values(values)
19761972
return klass(values, ndim=ndim, placement=placement)

pandas/core/internals/managers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1934,7 +1934,7 @@ def _form_blocks(arrays: list[ArrayLike], consolidate: bool) -> list[Block]:
19341934

19351935
nbs = []
19361936
for (_, _, dtype), tup_block in grouper:
1937-
block_type = get_block_type(None, dtype)
1937+
block_type = get_block_type(dtype)
19381938

19391939
if isinstance(dtype, np.dtype):
19401940
is_dtlike = dtype.kind in ["m", "M"]

0 commit comments

Comments
 (0)