Skip to content

Commit 61dcee3

Browse files
committed
Address merge comments
1 parent 62e0dde commit 61dcee3

File tree

2 files changed

+6
-13
lines changed

2 files changed

+6
-13
lines changed

pandas/core/groupby/groupby.py

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1755,12 +1755,8 @@ def cummin(self, axis=0, **kwargs):
17551755
if axis != 0:
17561756
return self.apply(lambda x: np.minimum.accumulate(x, axis))
17571757

1758-
if kwargs.get('numeric_only') or False:
1759-
numeric_only = kwargs.get('numeric_only')
1760-
else:
1761-
numeric_only = False
1762-
1763-
return self._cython_transform('cummin', numeric_only=numeric_only)
1758+
return self._cython_transform('cummin',
1759+
numeric_only=kwargs.get('numeric_only') or False)
17641760

17651761
@Substitution(name='groupby')
17661762
@Appender(_doc_template)
@@ -1769,12 +1765,8 @@ def cummax(self, axis=0, **kwargs):
17691765
if axis != 0:
17701766
return self.apply(lambda x: np.maximum.accumulate(x, axis))
17711767

1772-
if kwargs:
1773-
numeric_only = kwargs.get('numeric_only')
1774-
else:
1775-
numeric_only = False
1776-
1777-
return self._cython_transform('cummax', numeric_only=numeric_only)
1768+
return self._cython_transform('cummax',
1769+
numeric_only=kwargs.get('numeric_only') or False)
17781770

17791771
def _get_cythonized_result(self, how, grouper, aggregate=False,
17801772
cython_dtype=None, needs_values=False,

pandas/io/pytables.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3971,7 +3971,8 @@ def write(self, obj, axes=None, append=False, complib=None,
39713971

39723972
# create the axes
39733973
self.create_axes(axes=axes, obj=obj, validate=append,
3974-
min_itemsize=min_itemsize, **kwargs)
3974+
min_itemsize=min_itemsize,
3975+
**kwargs)
39753976

39763977
for a in self.axes:
39773978
a.validate(self, append)

0 commit comments

Comments
 (0)