CLN: Deprecate Index.summary (GH18217)

Review code changes

Author: GGordonGordon

pandas/core/frame.py

@@ -2341,7 +2341,7 @@ def __getitem__(self, key):
         try:
             if key in self.columns and not is_mi_columns:
                 return self._getitem_column(key)
-        except Exception:
+        except:
             pass
 
         # see if we can slice the rows
@@ -2843,7 +2843,7 @@ def _ensure_valid_index(self, value):
         if not len(self.index) and is_list_like(value):
             try:
                 value = Series(value)
-            except Exception:
+            except:
                 raise ValueError('Cannot set a frame with no defined index '
                                  'and a value that cannot be converted to a '
                                  'Series')
@@ -6828,7 +6828,7 @@ def convert(v):
                 values = np.array([convert(v) for v in values])
             else:
                 values = convert(values)
-        except Exception:
+        except:
             values = convert(values)
 
     else:

pandas/core/indexes/base.py

@@ -1386,6 +1386,11 @@ def _has_complex_internals(self):
         return False
 
     def _summary(self, name=None):
+        """
+        Return a summarized representation
+        .. deprecated:: 0.23.0
+           No longer supported
+        """
         if len(self) > 0:
             head = self[0]
             if (hasattr(head, 'format') and
@@ -1406,6 +1411,7 @@ def _summary(self, name=None):
 
     def summary(self, name=None):
         """
+        Return a summarized representation
         .. deprecated:: 0.23.0
            No longer supported
         """

pandas/core/indexes/datetimelike.py

@@ -1051,7 +1051,9 @@ def where(self, cond, other=None):
 
     def _summary(self, name=None):
         """
-        return a summarized representation
+        Return a summarized representation
+        .. deprecated:: 0.23.0
+           No longer supported
         """
         formatter = self._formatter_func
         if len(self) > 0:
@@ -1071,15 +1073,6 @@ def _summary(self, name=None):
         result = result.replace("'", "")
         return result
 
-    def summary(self, name=None):
-        """
-        .. deprecated:: 0.23.0
-           No longer supported
-        """
-        warnings.warn("'summary' is deprecated and will be removed in a "
-                      "future version.", FutureWarning, stacklevel=2)
-        return self._summary(name)
-
     def _concat_same_dtype(self, to_concat, name):
         """
         Concatenate to_concat which has the same class

pandas/tests/indexes/period/test_formats.py

@@ -207,10 +207,3 @@ def test_summary(self):
                                   exp6, exp7, exp8, exp9]):
             result = idx._summary()
             assert result == expected
-
-    def test_summary_deprecated(self):
-        # GH18217
-        idx = PeriodIndex(['2011-01-01'], freq='D')
-
-        with tm.assert_produces_warning(FutureWarning):
-            idx.summary()

pandas/tests/indexes/timedeltas/test_formats.py

@@ -5,8 +5,6 @@
 import pandas as pd
 from pandas import TimedeltaIndex
 
-import pandas.util.testing as tm
-
 
 class TestTimedeltaIndexRendering(object):
     @pytest.mark.parametrize('method', ['__repr__', '__unicode__', '__str__'])
@@ -69,11 +67,6 @@ def test_representation_to_series(self):
                 result = repr(pd.Series(idx))
                 assert result == expected
 
-    def test_summary_deprecated(self):
-        idx = TimedeltaIndex([], freq='D')
-        with tm.assert_produces_warning(FutureWarning):
-            idx.summary()
-
     def test_summary(self):
         # GH#9116
         idx1 = TimedeltaIndex([], freq='D')