Skip to content

Commit a4b6912

Browse files
committed
Re-add skips to verify the ResourceWarnings come from those tests
1 parent a4858ae commit a4b6912

File tree

5 files changed

+6
-0
lines changed

5 files changed

+6
-0
lines changed

pandas/tests/io/json/test_compression.py

+1
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ def test_read_zipped_json(datapath):
3232
assert_frame_equal(uncompressed_df, compressed_df)
3333

3434

35+
@pytest.mark.skip(reason='hunting for ResourceWarning due to open socket')
3536
@td.skip_if_not_us_locale
3637
def test_with_s3_url(compression, capfd):
3738
boto3 = pytest.importorskip('boto3')

pandas/tests/io/json/test_pandas.py

+1
Original file line numberDiff line numberDiff line change
@@ -1047,6 +1047,7 @@ def test_read_inline_jsonl(self):
10471047
expected = DataFrame([[1, 2], [1, 2]], columns=['a', 'b'])
10481048
assert_frame_equal(result, expected)
10491049

1050+
@pytest.mark.skip(reason='hunting for ResourceWarning due to open socket')
10501051
@td.skip_if_not_us_locale
10511052
def test_read_s3_jsonl(self, s3_resource):
10521053
# GH17200

pandas/tests/io/test_excel.py

+1
Original file line numberDiff line numberDiff line change
@@ -691,6 +691,7 @@ def test_read_from_http_url(self, ext):
691691
local_table = self.get_exceldf('test1', ext)
692692
tm.assert_frame_equal(url_table, local_table)
693693

694+
@pytest.mark.skip(reason='hunting for ResourceWarning due to open socket')
694695
@td.skip_if_no("s3fs")
695696
@td.skip_if_not_us_locale
696697
def test_read_from_s3_url(self, ext, capfd):

pandas/tests/io/test_parquet.py

+2
Original file line numberDiff line numberDiff line change
@@ -450,6 +450,7 @@ def test_categorical(self, pa):
450450
expected = df.assign(a=df.a.astype(object))
451451
check_round_trip(df, pa, expected=expected)
452452

453+
@pytest.mark.skip(reason='hunting for ResourceWarning due to open socket')
453454
def test_s3_roundtrip(self, df_compat, s3_resource, pa):
454455
# GH #19134
455456
check_round_trip(df_compat, pa,
@@ -528,6 +529,7 @@ def test_filter_row_groups(self, fp):
528529
result = read_parquet(path, fp, filters=[('a', '==', 0)])
529530
assert len(result) == 1
530531

532+
@pytest.mark.skip(reason='hunting for ResourceWarning due to open socket')
531533
def test_s3_roundtrip(self, df_compat, s3_resource, fp):
532534
# GH #19134
533535
check_round_trip(df_compat, fp,

pandas/tests/io/test_s3.py

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ def test_is_s3_url(self):
1212
assert not is_s3_url("s4://pandas/somethingelse.com")
1313

1414

15+
@pytest.mark.skip(reason='hunting for ResourceWarning due to open socket')
1516
def test_streaming_s3_objects(capfd):
1617
# GH17135
1718
# botocore gained iteration support in 1.10.47, can now be used in read_*

0 commit comments

Comments
 (0)