interval dtypes

Author: jreback

doc/source/whatsnew/v0.24.0.txt

@@ -45,7 +45,7 @@ ExtensionType Changes
 Other API Changes
 ^^^^^^^^^^^^^^^^^
 
--
+- Invalid consruction of ``IntervalDtype`` will now always raise a ``TypeError`` rather than a ``ValueError`` if the subdtype is invalid (:issue:`21185`)
 -
 -
 

pandas/core/dtypes/dtypes.py

@@ -730,7 +730,7 @@ def __new__(cls, subtype=None):
             try:
                 subtype = pandas_dtype(subtype)
             except TypeError:
-                raise ValueError("could not construct IntervalDtype")
+                raise TypeError("could not construct IntervalDtype")
 
         if is_categorical_dtype(subtype) or is_string_dtype(subtype):
             # GH 19016
@@ -756,6 +756,7 @@ def construct_from_string(cls, string):
             (string.startswith('interval') or
              string.startswith('Interval'))):
             return cls(string)
+
         msg = "a string needs to be passed, got type {typ}"
         raise TypeError(msg.format(typ=type(string)))
 

pandas/tests/dtypes/test_dtypes.py

@@ -9,7 +9,6 @@
 from pandas import (
     Series, Categorical, CategoricalIndex, IntervalIndex, date_range)
 
-from pandas.compat import string_types
 from pandas.core.dtypes.dtypes import (
     DatetimeTZDtype, PeriodDtype,
     IntervalDtype, CategoricalDtype, registry)
@@ -448,7 +447,7 @@ def test_construction_not_supported(self, subtype):
 
     def test_construction_errors(self):
         msg = 'could not construct IntervalDtype'
-        with tm.assert_raises_regex(ValueError, msg):
+        with tm.assert_raises_regex(TypeError, msg):
             IntervalDtype('xx')
 
     def test_construction_from_string(self):
@@ -458,14 +457,21 @@ def test_construction_from_string(self):
         assert is_dtype_equal(self.dtype, result)
 
     @pytest.mark.parametrize('string', [
-        'foo', 'interval[foo]', 'foo[int64]', 0, 3.14, ('a', 'b'), None])
+        'foo', 'foo[int64]', 0, 3.14, ('a', 'b'), None])
     def test_construction_from_string_errors(self, string):
-        if isinstance(string, string_types):
-            error, msg = ValueError, 'could not construct IntervalDtype'
-        else:
-            error, msg = TypeError, 'a string needs to be passed, got type'
+        # these are invalid entirely
+        msg = 'a string needs to be passed, got type'
+
+        with tm.assert_raises_regex(TypeError, msg):
+            IntervalDtype.construct_from_string(string)
 
-        with tm.assert_raises_regex(error, msg):
+    @pytest.mark.parametrize('string', [
+        'interval[foo]'])
+    def test_construction_from_string_error_subtype(self, string):
+        # this is an invalid subtype
+        msg = 'could not construct IntervalDtype'
+
+        with tm.assert_raises_regex(TypeError, msg):
             IntervalDtype.construct_from_string(string)
 
     def test_subclass(self):