Skip to content

Commit b2bc457

Browse files
committed
feedback: remove native arg/accept Timestamp return type
1 parent bebb60c commit b2bc457

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

pandas/core/common.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -78,19 +78,17 @@ def consensus_name_attr(objs):
7878
return name
7979

8080

81-
def maybe_box_datetimelike(value, dtype=None, native=False):
81+
def maybe_box_datetimelike(value, dtype=None):
8282
# turn a datetime like into a Timestamp/timedelta as needed
8383
if dtype == object:
8484
# If we dont have datetime64/timedelta64 dtype, we dont want to
8585
# box datetimelike scalars
8686
return value
8787

8888
if isinstance(value, (np.datetime64, datetime)):
89-
ts = tslibs.Timestamp(value)
90-
value = ts.to_pydatetime() if native else ts
89+
value = tslibs.Timestamp(value)
9190
elif isinstance(value, (np.timedelta64, timedelta)):
92-
td = tslibs.Timedelta(value)
93-
value = td.to_pydatetime() if native else td
91+
value = tslibs.Timedelta(value)
9492

9593
return value
9694

pandas/core/frame.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1538,10 +1538,7 @@ def to_dict(self, orient="dict", into=dict):
15381538
for row in self.itertuples(index=False, name=None)
15391539
)
15401540
return [
1541-
into_c(
1542-
(k, com.maybe_box_datetimelike(v, native=True))
1543-
for k, v in row.items()
1544-
)
1541+
into_c((k, com.maybe_box_datetimelike(v)) for k, v in row.items())
15451542
for row in rows
15461543
]
15471544

pandas/tests/frame/methods/test_to_dict.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ def test_to_dict_orient_dtype(self):
277277
"int": int,
278278
"float": float,
279279
"str": str,
280-
"datetime": datetime,
280+
"datetime": Timestamp,
281281
"bool": bool,
282282
}
283283

0 commit comments

Comments
 (0)