Skip to content

Commit b4de5c4

Browse files
committed
Merge branch 'index-values' into pandas-array-upstream+fu1
2 parents 4d08218 + 34a6a22 commit b4de5c4

File tree

4 files changed

+36
-3
lines changed

4 files changed

+36
-3
lines changed

pandas/core/base.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
is_list_like,
1414
is_scalar,
1515
is_datetimelike,
16-
is_categorical_dtype,
1716
is_extension_type,
1817
is_extension_array_dtype)
1918

@@ -712,7 +711,7 @@ def transpose(self, *args, **kwargs):
712711
@property
713712
def shape(self):
714713
""" return a tuple of the shape of the underlying data """
715-
return self._ndarray_values.shape
714+
return self._values.shape
716715

717716
@property
718717
def ndim(self):
@@ -755,7 +754,7 @@ def strides(self):
755754
@property
756755
def size(self):
757756
""" return the number of elements in the underlying data """
758-
return self._ndarray_values.size
757+
return self._values.size
759758

760759
@property
761760
def flags(self):

pandas/core/indexes/datetimes.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -694,6 +694,20 @@ def tzinfo(self):
694694
"""
695695
return self.tz
696696

697+
@property
698+
def size(self):
699+
# TODO: Remove this when we have a DatetimeTZArray
700+
# Necessary to avoid recursion error since DTI._values is a DTI
701+
# for TZ-aware
702+
return self._ndarray_values.size
703+
704+
@property
705+
def shape(self):
706+
# TODO: Remove this when we have a DatetimeTZArray
707+
# Necessary to avoid recursion error since DTI._values is a DTI
708+
# for TZ-aware
709+
return self._ndarray_values.shape
710+
697711
@cache_readonly
698712
def _timezone(self):
699713
""" Comparable timezone both for pytz / dateutil"""

pandas/core/indexes/interval.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -680,6 +680,16 @@ def length(self):
680680
'e.g. Intervals with string endpoints')
681681
raise TypeError(msg)
682682

683+
@property
684+
def size(self):
685+
# Avoid materializing self.values
686+
return self.left.size
687+
688+
@property
689+
def shape(self):
690+
# Avoid materializing self.values
691+
return self.left.shape
692+
683693
def __len__(self):
684694
return len(self.left)
685695

pandas/core/indexes/period.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -477,6 +477,16 @@ def _to_embed(self, keep_tz=False, dtype=None):
477477

478478
return self.astype(object).values
479479

480+
@property
481+
def size(self):
482+
# Avoid materializing self._values
483+
return self._ndarray_values.size
484+
485+
@property
486+
def shape(self):
487+
# Avoid materializing self._values
488+
return self._ndarray_values.shape
489+
480490
@property
481491
def _formatter_func(self):
482492
return lambda x: "'%s'" % x

0 commit comments

Comments
 (0)