Skip to content

Commit d101f45

Browse files
committed
BUG: Removing a nonexistent store raises a KeyError
1 parent dfaf365 commit d101f45

File tree

3 files changed

+86
-70
lines changed

3 files changed

+86
-70
lines changed

RELEASE.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ pandas 0.12.0
4040
4141
**API Changes**
4242

43-
-
43+
- When removing an object from a store, **store.remove(key)**, raises
44+
**KeyError** if **key** is not a valid store object.
4445

4546
**Bug Fixes**
4647

pandas/io/pytables.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -554,6 +554,10 @@ def remove(self, key, where=None, start=None, stop=None):
554554
-------
555555
number of rows removed (or None if not a Table)
556556
557+
Exceptions
558+
----------
559+
raises KeyError if key is not a valid store
560+
557561
"""
558562
try:
559563
s = self.get_storer(key)
@@ -569,7 +573,7 @@ def remove(self, key, where=None, start=None, stop=None):
569573
return None
570574

571575
if s is None:
572-
return None
576+
raise KeyError('No object named %s in the file' % key)
573577

574578
# remove the node
575579
if where is None:

0 commit comments

Comments
 (0)