CLN: Fix pylint undefined-loop-variable warnings

Author: Leviob

pandas/core/util/hashing.py

@@ -76,7 +76,7 @@ def combine_hash_arrays(
         out ^= a
         out *= mult
         mult += np.uint64(82520 + inverse_i + inverse_i)
-    assert i + 1 == num_items, "Fed in wrong num_items"
+    assert len(arrays) == num_items, "Fed in wrong num_items"
     out += np.uint64(97531)
     return out
 

pandas/io/excel/_base.py

@@ -883,7 +883,7 @@ def parse(
         if ret_dict:
             return output
         else:
-            return output[asheetname]
+            return output[asheetname]  # pylint: disable=undefined-loop-variable
 
 
 @doc(storage_options=_shared_docs["storage_options"])

pandas/io/formats/latex.py

@@ -160,8 +160,7 @@ def _get_strcols(self) -> list[list[str]]:
             def pad_empties(x):
                 for pad in reversed(x):
                     if pad:
-                        break
-                return [x[0]] + [i if i else " " * len(pad) for i in x[1:]]
+                        return [x[0]] + [i if i else " " * len(pad) for i in x[1:]]
 
             gen = (pad_empties(i) for i in out)
 

pandas/io/formats/printing.py

@@ -419,9 +419,9 @@ def best_len(values: list[str]) -> int:
             for max_items in reversed(range(1, len(value) + 1)):
                 pprinted_seq = _pprint_seq(value, max_seq_items=max_items)
                 if len(pprinted_seq) < max_space:
+                    head = [_pprint_seq(x, max_seq_items=max_items) for x in head]
+                    tail = [_pprint_seq(x, max_seq_items=max_items) for x in tail]
                     break
-            head = [_pprint_seq(x, max_seq_items=max_items) for x in head]
-            tail = [_pprint_seq(x, max_seq_items=max_items) for x in tail]
 
         summary = ""
         line = space2

pandas/io/formats/style.py

@@ -2298,6 +2298,7 @@ def set_sticky(
                             "selector": f"thead tr:nth-child({obj.nlevels+1}) th",
                             "props": props
                             + (
+                                # pylint: disable=undefined-loop-variable
                                 f"top:{(i+1) * pixel_size}px; height:{pixel_size}px; "
                                 "z-index:2;"
                             ),

pandas/tests/frame/methods/test_to_dict_of_blocks.py

@@ -25,6 +25,7 @@ def test_copy_blocks(self, float_frame):
                 _df.loc[:, column] = _df[column] + 1
 
         # make sure we did not change the original DataFrame
+        # pylint: disable-next=undefined-loop-variable
         assert not _df[column].equals(df[column])
 
     def test_no_copy_blocks(self, float_frame, using_copy_on_write):
@@ -40,8 +41,10 @@ def test_no_copy_blocks(self, float_frame, using_copy_on_write):
 
         if not using_copy_on_write:
             # make sure we did change the original DataFrame
+            # pylint: disable-next=undefined-loop-variable
             assert _df[column].equals(df[column])
         else:
+            # pylint: disable-next=undefined-loop-variable
             assert not _df[column].equals(df[column])
 
 

pandas/tests/frame/test_iteration.py

@@ -159,4 +159,4 @@ def test_sequence_like_with_categorical(self):
             str(s)
 
         for c, col in df.items():
-            str(s)
+            str(s)  # pylint: disable=undefined-loop-variable

pandas/tests/io/formats/test_printing.py

@@ -141,6 +141,7 @@ def test_publishes(self, ip):
         with_latex = pd.option_context("display.latex.repr", True)
 
         with opt, with_latex:
+            # pylint: disable-next=undefined-loop-variable
             formatted = ipython.display_formatter.format(obj)
 
         expected = {

pyproject.toml

@@ -153,7 +153,6 @@ disable = [
   "subprocess-run-check",
   "super-init-not-called",
   "try-except-raise",
-  "undefined-loop-variable",
   "unnecessary-lambda",
   "unspecified-encoding",
   "unused-argument",