Skip to content

Commit ddb315f

Browse files
authored
TYP: resolve ignored mypy errors in core/describe.py (#46928)
1 parent 5a599c1 commit ddb315f

File tree

2 files changed

+9
-14
lines changed

2 files changed

+9
-14
lines changed

pandas/core/describe.py

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@
2222
import numpy as np
2323

2424
from pandas._libs.tslibs import Timestamp
25-
from pandas._typing import NDFrameT
25+
from pandas._typing import (
26+
NDFrameT,
27+
npt,
28+
)
2629
from pandas.util._exceptions import find_stack_level
2730
from pandas.util._validators import validate_percentile
2831

@@ -186,11 +189,9 @@ def _select_data(self):
186189
"""Select columns to be described."""
187190
if (self.include is None) and (self.exclude is None):
188191
# when some numerics are found, keep only numerics
189-
default_include = [np.number]
192+
default_include: list[npt.DTypeLike] = [np.number]
190193
if self.datetime_is_numeric:
191-
# error: Argument 1 to "append" of "list" has incompatible type "str";
192-
# expected "Type[number[Any]]"
193-
default_include.append("datetime") # type: ignore[arg-type]
194+
default_include.append("datetime")
194195
data = self.obj.select_dtypes(include=default_include)
195196
if len(data.columns) == 0:
196197
data = self.obj
@@ -230,10 +231,7 @@ def describe_numeric_1d(series: Series, percentiles: Sequence[float]) -> Series:
230231
"""
231232
from pandas import Series
232233

233-
# error: Argument 1 to "format_percentiles" has incompatible type "Sequence[float]";
234-
# expected "Union[ndarray, List[Union[int, float]], List[float], List[Union[str,
235-
# float]]]"
236-
formatted_percentiles = format_percentiles(percentiles) # type: ignore[arg-type]
234+
formatted_percentiles = format_percentiles(percentiles)
237235

238236
stat_index = ["count", "mean", "std", "min"] + formatted_percentiles + ["max"]
239237
d = (
@@ -337,10 +335,7 @@ def describe_timestamp_1d(data: Series, percentiles: Sequence[float]) -> Series:
337335
# GH-30164
338336
from pandas import Series
339337

340-
# error: Argument 1 to "format_percentiles" has incompatible type "Sequence[float]";
341-
# expected "Union[ndarray, List[Union[int, float]], List[float], List[Union[str,
342-
# float]]]"
343-
formatted_percentiles = format_percentiles(percentiles) # type: ignore[arg-type]
338+
formatted_percentiles = format_percentiles(percentiles)
344339

345340
stat_index = ["count", "mean", "min"] + formatted_percentiles + ["max"]
346341
d = (

pandas/io/formats/format.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1667,7 +1667,7 @@ def _format_strings(self) -> list[str]:
16671667

16681668

16691669
def format_percentiles(
1670-
percentiles: (np.ndarray | list[int | float] | list[float] | list[str | float]),
1670+
percentiles: (np.ndarray | Sequence[float]),
16711671
) -> list[str]:
16721672
"""
16731673
Outputs rounded and formatted percentiles.

0 commit comments

Comments
 (0)