fix clip by casting to Series

Author: yl2526

pandas/core/generic.py

@@ -4430,7 +4430,10 @@ def _clip_with_one_bound(self, threshold, method, axis, inplace):
 
         # GH #15390
         if (not isinstance(threshold, ABCSeries)) and is_list_like(threshold):
-            threshold = np.asarray(threshold)
+            if isinstance(self, ABCSeries) or axis == 0:
+                threshold = pd.Series(threshold, index=self.index)
+            elif axis == 1:
+                threshold = pd.Series(threshold, index=self.columns)
         return self.where(subset, threshold, axis=axis, inplace=inplace)
 
     def clip(self, lower=None, upper=None, axis=None, inplace=False,

pandas/tests/frame/test_analytics.py

@@ -1893,17 +1893,19 @@ def test_clip_against_series(self, inplace):
             tm.assert_series_equal(clipped_df.loc[mask, i], df.loc[mask, i])
 
     @pytest.mark.parametrize("inplace", [True, False])
-    def test_clip_against_list(self, inplace):
+    @pytest.mark.parametrize("lower", [[2, 3, 4], np.asarray([2, 3, 4])])
+    @pytest.mark.parametrize("axis,res", [
+        (0, [[2., 2., 3.], [4., 5., 6.], [7., 7., 7.]]),
+        (1, [[2., 3., 4.], [4., 5., 6.], [5., 6., 7.]])
+    ])
+    def test_clip_against_list_like(self, inplace, lower, axis, res):
         # GH #15390
         original = self.simple.copy(deep=True)
 
-        result = original.clip(lower=[2, 3, 4], upper=[5, 6, 7],
-                               axis=1, inplace=inplace)
+        result = original.clip(lower=lower, upper=[5, 6, 7],
+                               axis=axis, inplace=inplace)
 
-        arr = np.array([[2., 3., 4.],
-                        [4., 5., 6.],
-                        [5., 6., 7.]])
-        expected = pd.DataFrame(arr,
+        expected = pd.DataFrame(res,
                                 columns=original.columns,
                                 index=original.index)
         if inplace:

pandas/tests/series/test_analytics.py

@@ -1016,10 +1016,11 @@ def test_clip_against_series(self):
         assert_series_equal(s.clip(1.5, upper), Series([1.5, 1.5, 3.5]))
 
     @pytest.mark.parametrize("inplace", [True, False])
-    def test_clip_against_list(self, inplace):
+    @pytest.mark.parametrize("upper", [[1, 2, 3], np.asarray([1, 2, 3])])
+    def test_clip_against_list_like(self, inplace, upper):
         # GH #15390
         original = pd.Series([5, 6, 7])
-        result = original.clip(upper=[1, 2, 3], inplace=inplace)
+        result = original.clip(upper=upper, inplace=inplace)
         expected = pd.Series([1, 2, 3])
 
         if inplace: