REF: Rename NonFixedVariableWindowIndexer to VariableOffsetWindowIndexer (#35059)

Co-authored-by: Matt Roeschke <[email protected]>

Author: mroeschke

doc/source/user_guide/computation.rst

@@ -597,15 +597,15 @@ You can view other examples of ``BaseIndexer`` subclasses `here <https://github.
 
 .. versionadded:: 1.1
 
-One subclass of note within those examples is the ``NonFixedVariableWindowIndexer`` that allows
+One subclass of note within those examples is the ``VariableOffsetWindowIndexer`` that allows
 rolling operations over a non-fixed offset like a ``BusinessDay``.
 
 .. ipython:: python
 
-   from pandas.api.indexers import NonFixedVariableWindowIndexer
+   from pandas.api.indexers import VariableOffsetWindowIndexer
    df = pd.DataFrame(range(10), index=pd.date_range('2020', periods=10))
    offset = pd.offsets.BDay(1)
-   indexer = NonFixedVariableWindowIndexer(index=df.index, offset=offset)
+   indexer = VariableOffsetWindowIndexer(index=df.index, offset=offset)
    df
    df.rolling(indexer).sum()
 

doc/source/whatsnew/v1.1.0.rst

@@ -673,7 +673,7 @@ Other API changes
 - ``loc`` lookups with an object-dtype :class:`Index` and an integer key will now raise ``KeyError`` instead of ``TypeError`` when key is missing (:issue:`31905`)
 - Using a :func:`pandas.api.indexers.BaseIndexer` with ``count``, ``min``, ``max``, ``median``, ``skew``,  ``cov``, ``corr`` will now return correct results for any monotonic :func:`pandas.api.indexers.BaseIndexer` descendant (:issue:`32865`)
 - Added a :func:`pandas.api.indexers.FixedForwardWindowIndexer` class to support forward-looking windows during ``rolling`` operations.
-- Added a :func:`pandas.api.indexers.NonFixedVariableWindowIndexer` class to support ``rolling`` operations with non-fixed offsets (:issue:`34994`)
+- Added a :func:`pandas.api.indexers.VariableOffsetWindowIndexer` class to support ``rolling`` operations with non-fixed offsets (:issue:`34994`)
 - Added :class:`pandas.errors.InvalidIndexError` (:issue:`34570`).
 - :meth:`DataFrame.swaplevels` now raises a  ``TypeError`` if the axis is not a :class:`MultiIndex`.
   Previously an ``AttributeError`` was raised (:issue:`31126`)

pandas/api/indexers/__init__.py

@@ -6,12 +6,12 @@
 from pandas.core.window.indexers import (
     BaseIndexer,
     FixedForwardWindowIndexer,
-    NonFixedVariableWindowIndexer,
+    VariableOffsetWindowIndexer,
 )
 
 __all__ = [
     "check_array_indexer",
     "BaseIndexer",
     "FixedForwardWindowIndexer",
-    "NonFixedVariableWindowIndexer",
+    "VariableOffsetWindowIndexer",
 ]

pandas/core/window/indexers.py

@@ -107,7 +107,7 @@ def get_window_bounds(
         )
 
 
-class NonFixedVariableWindowIndexer(BaseIndexer):
+class VariableOffsetWindowIndexer(BaseIndexer):
     """Calculate window boundaries based on a non-fixed offset such as a BusinessDay"""
 
     def __init__(

pandas/tests/window/test_base_indexer.py

@@ -4,7 +4,7 @@
 from pandas import DataFrame, Series, date_range
 import pandas._testing as tm
 from pandas.api.indexers import BaseIndexer, FixedForwardWindowIndexer
-from pandas.core.window.indexers import ExpandingIndexer, NonFixedVariableWindowIndexer
+from pandas.core.window.indexers import ExpandingIndexer, VariableOffsetWindowIndexer
 
 from pandas.tseries.offsets import BusinessDay
 
@@ -249,7 +249,7 @@ def test_non_fixed_variable_window_indexer(closed, expected_data):
     index = date_range("2020", periods=10)
     df = DataFrame(range(10), index=index)
     offset = BusinessDay(1)
-    indexer = NonFixedVariableWindowIndexer(index=index, offset=offset)
+    indexer = VariableOffsetWindowIndexer(index=index, offset=offset)
     result = df.rolling(indexer, closed=closed).sum()
     expected = DataFrame(expected_data, index=index)
     tm.assert_frame_equal(result, expected)