BUG: Preserve sparse dtype when reindexing #26183
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @alex-hutton! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-04-22 12:35:45 UTC |
alex-hutton
force-pushed
the
preserve-sparse-dtype-26123
branch
from
534aed6 to
b8754b6
Compare
- This is currently broken due to many tests relying on possibly broken behaviour. - BUG pandas-dev#26123.
alex-hutton
force-pushed
the
preserve-sparse-dtype-26123
branch
from
b8754b6 to
6b9035c
Compare
alex-hutton
changed the title
gfyoung
added
Bug
Regression
jreback
requested changes
Apr 28, 2019
| @@ -4527,7 +4527,8 @@ def _reindex_with_indexers(self, reindexers, fill_value=None, copy=False, | |||
| if copy and new_data is self._data: | |||
| new_data = new_data.copy() | |||
|
|
|||
| return self._constructor(new_data).__finalize__(self) | |||
| kwargs = {'dtype': self._data.dtype} if preserve_dtype else {} | |||
There was a problem hiding this comment.
what happens if you always just pass the dtype of the original in
|
closing as stale. if you'd to continue, pls merge master and ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffHi, I've been taking a look at this but I need to verify some of the surrounding functionality so that I prevent introducing more breakages.
In this test, https://github.com/alex-hutton/pandas/blob/preserve-sparse-dtype-26123/pandas/tests/sparse/test_combine_concat.py#L99-L110 , my interpretation is that its purpose is to verify that if two
SparseSeriesare concatenated, afill_valueset on either of thoseSparseSeriesshould be ignored in favour of the defaultfill_valueofNaN.Is my interpretation correct, and is this test correct? It seems odd that the the
fill_valueof theSparseSeriesshould be disregarded, but I am probably missing something.