Fix: StringArray non-extensible due to inconsisent assertion #34310
Conversation
sbrugman
changed the title
|
@dsaxton Thanks for your review. I've processed your proposed changes and added an additional string dtype test. |
Done |
|
I think the issue has an ongoing discussion that needs to be resolved. |
|
@sbrugman can you merge master just to keep this from drifting |
| @@ -196,7 +196,7 @@ def _validate(self): | |||
| @classmethod | |||
| def _from_sequence(cls, scalars, dtype=None, copy=False): | |||
| if dtype: | |||
| assert dtype == "string" | |||
| assert isinstance(dtype, StringDtype) | |||
There was a problem hiding this comment.
im not sure this is right. cc @TomAugspurger ?
There was a problem hiding this comment.
They're equivalent right now, but that may be changing in the future with an arrow-backed string array.
But my main objection to this was the original motivation from the issue not being a supported use case.
There was a problem hiding this comment.
@TomAugspurger if you dont think this should be supported, should this PR be closed?
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
Fix for #34309
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff