Skip to content

Remove obj_with_exclusions #50878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Remove obj_with_exclusions #50878

wants to merge 7 commits into from

Conversation

rhshadrach
Copy link
Member

Built on #50846; just testing whether obj_with_exclusions is now the same as selected_obj with the exception of #50805

@rhshadrach rhshadrach added Refactor Internal refactoring of code Groupby labels Jan 19, 2023
@rhshadrach rhshadrach marked this pull request as draft January 19, 2023 22:16
@jbrockmendel
Copy link
Member

(Not having looked at the code) nice!

@rhshadrach rhshadrach mentioned this pull request Jan 31, 2023
Open
@jbrockmendel
Copy link
Member

Is this still viable?

@rhshadrach
Copy link
Member Author

Nope - closing.

@rhshadrach rhshadrach closed this Feb 8, 2023
@rhshadrach rhshadrach deleted the remove_obj_with_exclusions branch February 8, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Groupby Refactor Internal refactoring of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLN/DOC: _selected_obj vs _obj_with_exclusions
2 participants
@rhshadrach @jbrockmendel