Fixes NonExistentTimeError when resampling weekly #54609
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
omar-elbaz
commented
Aug 18, 2023
omar-elbaz
commented
- closes BUG: Unnecessary NonExistentTimeError when resampling weekly #53666
- Tests added and passed
- All code checks passed.
MarcoGorelli
suggested changes
Aug 18, 2023
There was a problem hiding this comment.
Thanks for your PR!
To be honest I'm not sure this is the solution, I think we need to re-evaluate how the windows are determined
The end-points of the windows are not on ambiguous datetimes, so there's no reason why we should be hitting a non-existent datetime
|
@MarcoGorelli thanks for reviewing. |
|
@mroeschke Please could you help my mentee with advice/review here? Thanks |
|
Sorry for the delay here. I don't think anyone on the core team has bandwidth right now to suggest a quick solution to this complex issue right now. As alluded to in #54609 (review), this may require a larger refactor. Going to close for now, but happy to have contribution on other issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.