FIX: query() and isin() fail on period type column #54214
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyi96
changed the title
dannyi96
commented
Jul 21, 2023
| @@ -501,6 +502,8 @@ def isin(comps: ListLike, values: ListLike) -> npt.NDArray[np.bool_]: | |||
| comps_array = extract_array(comps_array, extract_numpy=True) | |||
| if not isinstance(comps_array, np.ndarray): | |||
| # i.e. Extension Array | |||
| if isinstance(comps_array.dtype, PeriodDtype): | |||
| comps_array = comps_array.to_timestamp() | |||
| return comps_array.isin(values) | |||
|
|
|||
There was a problem hiding this comment.
2 testcases fail post this change, looking into it
FAILED pandas/tests/indexes/test_datetimelike.py::TestDatetimeLike::test_isin[simple_index0] - TypeError: Passing PeriodDtype data is invalid. Use `data.to_timestamp()` instead
FAILED pandas/tests/series/methods/test_isin.py::TestSeriesIsIn::test_isin_period_freq_mismatch - TypeError: Passing PeriodDtype data is invalid. Use `data.to_timestamp()` instead
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
|
hi @mroeschke , I've made some changes to address the failing testcases and pushed to this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.query()andisin()fail on period type column #54199doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.