Skip to content

BUG: Fix #54763 to_julian_date does not consider timezone #60280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tev-dixon
Copy link
Contributor

@tev-dixon
Copy link
Contributor Author

The merge conflict in pandas/_libs/tslibs/timestamps.pyx is because I changed how the additions/subtractions were styled to improve readability. I had to insert a minus for the timezone_offset and it did not make sense to have it on the previous line. This format is also more consistent with the other files I was working in.

Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Dec 12, 2024
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Timestamp.to_julian_date() does not take into account timezone
2 participants