Skip to content

Updates to check the dtypes instead #55965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lazarust
Copy link
Contributor

@lazarust lazarust commented Nov 15, 2023

@lazarust lazarust marked this pull request as ready for review November 15, 2023 01:49
@@ -1424,7 +1426,7 @@ def _kind(self) -> Literal["hexbin"]:

def __init__(self, data, x, y, C=None, *, colorbar: bool = True, **kwargs) -> None:
super().__init__(data, x, y, **kwargs)
if is_integer(C) and not self.data.columns._holds_integer():
if is_integer(C) and not (self.data.dtypes == "int").any():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this we'd want to use is_integer_dtype. we'd also need to check for object dtype that _holds_integer and issue a warning that it is deprecated and the user should cast (similar above)

@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REF/API/DEPR: _holds_integer checks in plotting
3 participants