Skip to content

Commit bb8bb39

Browse files
committed
update ci for update carthage
1 parent 02fb65a commit bb8bb39

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,10 +135,11 @@ jobs:
135135
sudo gem install bundler
136136
bundle config set path 'vendor/bundle'
137137
bundle install
138+
carthage update --use-xcframeworks
138139
- name: Build-Test
139-
run: set -o pipefail && env NSUnbufferedIO=YES bundle exec rake test:parseui:all
140140
env:
141141
DEVELOPER_DIR: ${{ env.CI_XCODE_13 }}
142+
run: set -o pipefail && env NSUnbufferedIO=YES bundle exec rake test:parseui:all
142143
- name: Send codecov
143144
run: bash <(curl https://codecov.io/bash)
144145

Rakefile

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,6 @@ namespace :test do
558558

559559
namespace :parseui do
560560
task :all do
561-
Rake::Task['test:parseui:build_carthage'].invoke
562561
Rake::Task['test:parseui:framework'].invoke
563562
Rake::Task['test:parseui:demo_objc'].invoke
564563
end
@@ -584,13 +583,6 @@ namespace :test do
584583
end
585584
end
586585

587-
task :build_carthage do |_|
588-
if !system('carthage update facebook-ios-sdk --use-xcframeworks')
589-
puts 'Carthage Tests Failed!'
590-
exit(1)
591-
end
592-
end
593-
594586
task :demo_objc do
595587
task = XCTask::BuildTask.new do |t|
596588
t.directory = script_folder

0 commit comments

Comments
 (0)