Skip to content

Commit 0d8b8bd

Browse files
paulovitinflovilmart
authored andcommitted
Set initial audience null and validate to prevent forgetfulness (#910)
1 parent 4a580a9 commit 0d8b8bd

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/dashboard/Push/PushNew.react.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ class PushNew extends DashboardView {
133133
this.state = {
134134
pushAudiencesFetched: false,
135135
deviceCount: null,
136-
initialAudienceId: 'everyone',
136+
initialAudienceId: null,
137137
audienceSizeSuggestion: null,
138138
recipientCount: null,
139139
isLocalizationAvailable: false,
@@ -632,7 +632,7 @@ class PushNew extends DashboardView {
632632
pushAudiencesStore={this.props.pushaudiences}
633633
current={fields.audience_id}
634634
onChange={(audienceId, queryOrFilters, deviceCount) => {
635-
this.setState({ deviceCount });
635+
this.setState({ deviceCount, audienceId });
636636
setField('audience_id', audienceId);
637637
if (audienceId === PushConstants.NEW_SEGMENT_ID) {
638638
// Horrible code here is due to old rails code that sent pushes through it's own endpoint, while Parse Server sends through Parse.Push.
@@ -727,6 +727,11 @@ class PushNew extends DashboardView {
727727
valid(changes) {
728728
let emptyInputMessages = [];
729729
let invalidInputMessages = [];
730+
731+
if (!this.state.audienceId) {
732+
emptyInputMessages.push('you need select an audience');
733+
}
734+
730735
// when number audience size is 0
731736
if (this.state.deviceCount === 0) {
732737
emptyInputMessages.push('recipient count for this campaign');

0 commit comments

Comments
 (0)