Skip to content

Commit 230fc14

Browse files
authored
feat: improve button labels to be more concise in text (#2207)
1 parent f290e54 commit 230fc14

21 files changed

+54
-54
lines changed

src/dashboard/Account/AccountOverview.react.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ export default class AccountOverview extends React.Component {
291291
onClose={() => {
292292
this.setState({showAccountKeyModal: false});
293293
}}
294-
submitText='Create Key'
294+
submitText='Create'
295295
inProgressText={'Creating\u2026'}
296296
clearFields={() => {
297297
this.setState({accountKeyName: ''});
@@ -332,7 +332,7 @@ export default class AccountOverview extends React.Component {
332332
subtitle='If you delete this account key, anything that was using it will stop working.'
333333
type={Modal.Types.DANGER}
334334
open={this.state.showDeleteAccountKeyModal}
335-
submitText='Yes, delete it'
335+
submitText='Delete'
336336
inProgressText={'Deleting\u2026'}
337337
onSubmit={() => {
338338
return AccountManager.deleteAccountKeyById(this.state.accountKeyIdToDelete);

src/dashboard/Data/Browser/AddColumnDialog.react.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -200,10 +200,10 @@ export default class AddColumnDialog extends React.Component {
200200
title='Add a new column'
201201
subtitle='Store another type of data in this class.'
202202
disabled={!this.valid()}
203-
confirmText='Add column'
204-
cancelText={'Never mind, don\u2019t.'}
203+
confirmText='Add'
204+
cancelText='Cancel'
205205
onCancel={this.props.onCancel}
206-
continueText={'Add column & continue'}
206+
continueText={'Add & continue'}
207207
showContinue={true}
208208
onContinue={() => {
209209
this.props.onContinue(this.state);

src/dashboard/Data/Browser/AttachRowsDialog.react.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export default class AttachRowsDialog extends React.Component {
4343
onClose={this.props.onCancel}
4444
onSubmit={this.handleConfirm}
4545
submitText="Attach"
46-
inProgressText="Attaching ..."
46+
inProgressText={'Attaching\u2026'}
4747
>
4848
<Field
4949
label={

src/dashboard/Data/Browser/AttachSelectedRowsDialog.react.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ export default class AttachSelectedRowsDialog extends React.Component {
128128
iconSize={40}
129129
title="Attach Selected Rows to Relation"
130130
submitText="Attach"
131-
inProgressText="Attaching ..."
131+
inProgressText={'Attaching\u2026'}
132132
onClose={this.props.onCancel}
133133
onSubmit={this.handleConfirm}
134134
>

src/dashboard/Data/Browser/CloneSelectedRowsDialog.react.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ export default class CloneSelectedRowsDialog extends React.Component {
5656
title={this.props.selection['*'] ? 'Clone all rows?' : (selectionLength === 1 ? 'Clone this row?' : `Clone ${selectionLength} rows?`)}
5757
subtitle={''}
5858
disabled={!this.valid()}
59-
confirmText={'Yes clone'}
60-
cancelText={'Never mind, don\u2019t.'}
59+
confirmText='Clone'
60+
cancelText='Cancel'
6161
onCancel={this.props.onCancel}
6262
onConfirm={this.props.onConfirm}>
6363
{content}

src/dashboard/Data/Browser/CreateClassDialog.react.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,12 @@ export default class CreateClassDialog extends React.Component {
6464
type={Modal.Types.INFO}
6565
icon='plus'
6666
iconSize={40}
67-
title='Add a new class'
68-
subtitle='Create a new collection of objects.'
67+
title='Create a new class?'
68+
subtitle='This creates a new class to hold objects.'
6969
disabled={!this.valid()}
70-
confirmText='Create class'
71-
cancelText={'Cancel'}
72-
continueText={'Create class & add columns'}
70+
confirmText='Create'
71+
cancelText='Cancel'
72+
continueText={'Create & add columns'}
7373
onCancel={this.props.onCancel}
7474
showContinue={true}
7575
onContinue={async () => {

src/dashboard/Data/Browser/DeleteRowsDialog.react.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ export default class DeleteRowsDialog extends React.Component {
5757
title={this.props.selection['*'] ? `${deleteText} all rows?` : (selectionLength === 1 ? `${deleteText} this row?` : `${deleteText} ${selectionLength} rows?`)}
5858
subtitle={this.props.relation ? 'You need to delete origin record. This is a reference.' : 'This action cannot be undone!'}
5959
disabled={!this.valid()}
60-
confirmText={`Yes, ${this.props.relation ? 'detach' : 'delete'}`}
61-
cancelText={'Never mind, don\u2019t.'}
60+
confirmText='Delete'
61+
cancelText='Cancel'
6262
onCancel={this.props.onCancel}
6363
onConfirm={this.props.onConfirm}>
6464
{content}

src/dashboard/Data/Browser/DropClassDialog.react.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ export default class DropClassDialog extends React.Component {
3535
title='Delete this class?'
3636
subtitle='This action cannot be undone!'
3737
disabled={!this.valid()}
38-
confirmText='Yes, delete.'
39-
cancelText={'Never mind, don\u2019t.'}
38+
confirmText='Delete'
39+
cancelText='Cancel'
4040
onCancel={this.props.onCancel}
4141
onConfirm={this.props.onConfirm}>
4242
<Field

src/dashboard/Data/Browser/ExportDialog.react.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export default class ExportDialog extends React.Component {
4646
type={Modal.Types.INFO}
4747
icon='down-outline'
4848
iconSize={40}
49-
title='Export this class'
49+
title='Export this class?'
5050
subtitle={'We\'ll send you an email when your data is ready.'}
5151
confirmText='Export'
5252
cancelText='Cancel'

src/dashboard/Data/Browser/ExportSelectedRowsDialog.react.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ export default class ExportSelectedRowsDialog extends React.Component {
3030
title={this.props.selection['*'] ? 'Export all rows?' : (selectionLength === 1 ? 'Export 1 selected row?' : `Export ${selectionLength} selected rows?`)}
3131
subtitle={this.props.selection['*'] ? 'Note: Exporting is limited to the first 10,000 rows.' : ''}
3232
disabled={!this.valid()}
33-
confirmText={'Yes export'}
34-
cancelText={'Never mind, don\u2019t.'}
33+
confirmText='Export'
34+
cancelText='Cancel'
3535
onCancel={this.props.onCancel}
3636
onConfirm={this.props.onConfirm}>
3737
{}

src/dashboard/Data/Browser/PointerKeyDialog.react.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ export default class PointerKeyDialog extends React.Component {
5252
return (
5353
<Modal
5454
type={Modal.Types.INFO}
55-
title={'Change pointer key'}
55+
title={'Change pointer key?'}
5656
subtitle={hasColumns ? `The selected column will be used to represent a pointer for class "${this.props.className}"` : `There are no columns that can be set to represent a pointer for class "${this.props.className}"`}
57-
confirmText='Set pointer key'
58-
cancelText={'Never mind, don\u2019t.'}
57+
confirmText='Change'
58+
cancelText='Cancel'
5959
onCancel={this.props.onCancel}
6060
disabled={!this.state.name}
6161
onConfirm={() => {

src/dashboard/Data/Browser/RemoveColumnDialog.react.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,10 @@ export default class RemoveColumnDialog extends React.Component {
4646
<Modal
4747
type={Modal.Types.DANGER}
4848
icon='warn-outline'
49-
title='Remove a column'
49+
title='Remove a column?'
5050
subtitle={hasColumns ? 'Be careful, this action cannot be undone.' : 'There are no removable columns on this class.'}
51-
confirmText='Remove column'
52-
cancelText={'Never mind, don\u2019t.'}
51+
confirmText='Remove'
52+
cancelText='Cancel'
5353
onCancel={this.props.onCancel}
5454
disabled={!this.state.name}
5555
onConfirm={() => {

src/dashboard/Data/Browser/SecureFieldsDialog.react.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ export default class SecureFieldsDialog extends React.Component {
128128
protectedFields={this.props.perms.protectedFields}
129129
enablePointerPermissions={parseServerSupportsPointerPermissions}
130130
advanced={true}
131-
confirmText="Save Fields"
131+
confirmText="Save"
132132
details={
133133
<a
134134
target="_blank"

src/dashboard/Data/Browser/SecurityDialog.react.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,10 +122,10 @@ export default class SecurityDialog extends React.Component {
122122
details={<a target="_blank" href='http://docs.parseplatform.org/ios/guide/#security'>Learn more about CLPs and app security</a>}
123123
permissions={this.props.perms}
124124
userPointers={this.props.userPointers}
125-
validateEntry={entry =>
125+
validateEntry={entry =>
126126
validateEntry(this.props.userPointers, entry, parseServerSupportsPointerPermissions)}
127127
onCancel={this.handleClose}
128-
onConfirm={perms =>
128+
onConfirm={perms =>
129129
this.props.onChangeCLP(perms).then(this.handleClose)}
130130
/>
131131
);
@@ -134,7 +134,7 @@ export default class SecurityDialog extends React.Component {
134134
if (this.props.disabled) {
135135
classes.push(styles.toolbarButtonDisabled);
136136
}
137-
137+
138138
return dialog;
139139
}
140140
}

src/dashboard/Data/Config/ConfigDialog.react.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -203,8 +203,8 @@ export default class ConfigDialog extends React.Component {
203203
iconSize={30}
204204
subtitle={'Dynamically configure parts of your app'}
205205
disabled={!this.valid()}
206-
confirmText={newParam ? 'Create parameter' : 'Save parameter'}
207-
cancelText={'Cancel'}
206+
confirmText={newParam ? 'Create' : 'Save'}
207+
cancelText='Cancel'
208208
onCancel={this.props.onCancel}
209209
onConfirm={this.submit.bind(this)}>
210210
<Field
@@ -233,13 +233,13 @@ export default class ConfigDialog extends React.Component {
233233
description='Use this to configure your app. You can change it at any time.' />
234234
}
235235
input={EDITORS[this.state.type](this.state.value, (value) => { this.setState({ value }) })} />
236-
236+
237237
{
238238
/*
239239
Add `Requires master key` field if parse-server version >= 3.9.0,
240240
that is the minimum version that supports this feature.
241241
*/
242-
semver.valid(this.props.parseServerVersion) && semver.gte(this.props.parseServerVersion, '3.9.0')
242+
semver.valid(this.props.parseServerVersion) && semver.gte(this.props.parseServerVersion, '3.9.0')
243243
? <Field
244244
label={
245245
<Label
@@ -250,7 +250,7 @@ export default class ConfigDialog extends React.Component {
250250
<Toggle
251251
type={Toggle.Types.YES_NO}
252252
value={this.state.masterKeyOnly}
253-
onChange={(masterKeyOnly) => this.setState({ masterKeyOnly })}
253+
onChange={(masterKeyOnly) => this.setState({ masterKeyOnly })}
254254
additionalStyles={{ margin: '0px' }} />
255255
}
256256
className={styles.addColumnToggleWrapper}

src/dashboard/Data/Config/DeleteParameterDialog.react.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,11 @@ export default class DeleteParameterDialog extends React.Component {
4646
<Modal
4747
type={Modal.Types.DANGER}
4848
icon='warn-outline'
49-
title={'Delete parameter?'}
50-
subtitle={'This action cannot be undone!'}
49+
title='Delete parameter?'
50+
subtitle='This action cannot be undone!'
5151
disabled={!this.valid()}
52-
confirmText={'Yes, delete'}
53-
cancelText={'Never mind, don\u2019t.'}
52+
confirmText='Delete'
53+
cancelText='Cancel'
5454
onCancel={this.props.onCancel}
5555
onConfirm={this.props.onConfirm}>
5656
{content}

src/dashboard/Data/Jobs/Jobs.react.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,8 @@ class Jobs extends TableView {
230230
type={Modal.Types.DANGER}
231231
title='Delete job schedule?'
232232
subtitle='Careful, this action cannot be undone'
233-
confirmText='Yes, delete it'
234-
cancelText={'Never mind, don\'t'}
233+
confirmText='Delete'
234+
cancelText='Cancel'
235235
onCancel={() => this.setState({ toDelete: null })}
236236
onConfirm={() => {
237237
this.setState({ toDelete: null });

src/dashboard/Data/Webhooks/Webhooks.react.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ class Webhooks extends TableView {
166166
onClose={() => {
167167
this.setState({showNewWebhookModal: false});
168168
}}
169-
submitText='Create Webhook'
169+
submitText='Create'
170170
inProgressText={'Creating\u2026'}
171171
clearFields={this.clearFields.bind(this)}
172172
enabled={true /* TODO: do some validation here */}>
@@ -184,7 +184,7 @@ class Webhooks extends TableView {
184184
onClose={() => {
185185
this.setState({showEditWebhookModal: false});
186186
}}
187-
submitText='Save Webhook'
187+
submitText='Save'
188188
inProgressText={'Saving\u2026'}
189189
clearFields={this.clearFields.bind(this)}
190190
enabled={true /* TODO: do some validation here */}>
@@ -212,7 +212,7 @@ class Webhooks extends TableView {
212212
onClose={() => {
213213
this.setState({showDeleteWebhookModal: false});
214214
}}
215-
submitText='Delete Webhook'
215+
submitText='Delete'
216216
inProgressText={'Deleting\u2026'}
217217
clearFields={() => {
218218
this.setState({

src/dashboard/Settings/AppleCerts.react.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,10 @@ export default class AppleCerts extends React.Component {
6161
{this.state.deletePending === null ? null :
6262
<Modal
6363
type={Modal.Types.DANGER}
64-
title='Delete this certificate'
64+
title='Delete this certificate?'
6565
subtitle='Notifications will no longer be sent to the associated app.'
66-
cancelText={'Cancel'}
67-
confirmText={'Delete it!'}
66+
cancelText='Cancel'
67+
confirmText='Delete'
6868
onCancel={() => this.setState({ deletePending: null })}
6969
onConfirm={() => {
7070
let id = this.state.deletePending;

src/dashboard/Settings/GeneralSettings.react.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -409,8 +409,8 @@ export default class GeneralSettings extends DashboardView {
409409
iconSize={30}
410410
type={Modal.Types.DANGER}
411411
open={this.state.showMigrateAppModal}
412-
submitText={this.state.migrationWarnings && this.state.migrationWarnings.length > 0 ? 'Migrate anyway' : 'Begin the migration'}
413-
inProgressText={'Beginning the migration\u2026'}
412+
submitText={this.state.migrationWarnings && this.state.migrationWarnings.length > 0 ? 'Migrate anyway' : 'Migrate'}
413+
inProgressText={'Migrating\u2026'}
414414
showErrors={this.state.showMongoConnectionValidationErrors}
415415
width={900}
416416
onSubmit={() => {
@@ -463,7 +463,7 @@ export default class GeneralSettings extends DashboardView {
463463
}}
464464
onClose={closeModalWithConnectionString}
465465
type={Modal.Types.DANGER}
466-
submitText={this.state.migrationWarnings && this.state.migrationWarnings.length > 0 ? 'Change anyway' : 'Change connection string'}
466+
submitText={this.state.migrationWarnings && this.state.migrationWarnings.length > 0 ? 'Change anyway' : 'Change'}
467467
inProgressText={'Changing\u2026'}
468468
showErrors={this.state.showMongoConnectionValidationErrors}
469469
width={900}
@@ -494,7 +494,7 @@ export default class GeneralSettings extends DashboardView {
494494
iconSize={30}
495495
type={Modal.Types.DANGER}
496496
open={this.state.showTransferAppModal}
497-
submitText='Transfer ownership'
497+
submitText='Transfer'
498498
inProgressText={'Transferring\u2026'}
499499
enabled={
500500
(this.state.password.length > 0 || !AccountManager.currentUser().has_password)
@@ -531,7 +531,7 @@ export default class GeneralSettings extends DashboardView {
531531
subtitle='This is an irreversible action!'
532532
type={Modal.Types.DANGER}
533533
open={this.state.showDeleteAppModal}
534-
submitText='Permanently delete this app'
534+
submitText='Delete'
535535
inProgressText={'Deleting\u2026'}
536536
enabled={this.state.password.length > 0}
537537
onSubmit={() => AppsManager.deleteApp(this.context.slug, this.state.password)}

src/dashboard/Settings/SecuritySettings.react.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export default class SecuritySettings extends DashboardView {
4848
}
4949
open={this.state.showResetDialog}
5050
type={Modal.Types.DANGER}
51-
submitText='Reset it'
51+
submitText='Reset'
5252
inProgressText={'Resetting\u2026'}
5353
enabled={this.state.passwordInput.length > 0 || !AccountManager.currentUser().has_password}
5454
onSubmit={() => currentApp.resetMasterKey(this.state.passwordInput)}

0 commit comments

Comments
 (0)