Skip to content

Commit febd111

Browse files
JStonevalleyflovilmart
authored andcommitted
feat(RemoveColumnDialog): Remove default value and add placeholder (#969)
1 parent 68432e7 commit febd111

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/dashboard/Data/Browser/RemoveColumnDialog.react.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ import Option from 'components/Dropdown/Option.react';
1515
import React from 'react';
1616

1717
export default class RemoveColumnDialog extends React.Component {
18-
constructor(props) {
18+
constructor() {
1919
super();
2020
this.state = {
21-
name: props.currentColumns[0]
21+
name: null
2222
};
2323
}
2424

@@ -34,6 +34,7 @@ export default class RemoveColumnDialog extends React.Component {
3434
}
3535
input={
3636
<Dropdown
37+
placeHolder='Select a column'
3738
value={this.state.name}
3839
onChange={(name) => this.setState({ name: name })}>
3940
{this.props.currentColumns.map((t) => <Option key={t} value={t}>{t}</Option>)}
@@ -50,6 +51,7 @@ export default class RemoveColumnDialog extends React.Component {
5051
confirmText='Remove column'
5152
cancelText={'Never mind, don\u2019t.'}
5253
onCancel={this.props.onCancel}
54+
disabled={!this.state.name}
5355
onConfirm={() => {
5456
this.props.onConfirm(this.state.name);
5557
}}

0 commit comments

Comments
 (0)