Strip objectId out of responses from HooksController

Author: TylerBrock

src/Routers/HooksRouter.js

@@ -4,6 +4,16 @@ import { HooksController } from '../Controllers/HooksController';
 import * as middleware from "../middlewares";
 
 export class HooksRouter extends PromiseRouter {
+
+  static stripObjectId(result) {
+    delete result.objectId;
+    return result;
+  }
+
+  static stripObjectIds(results) {
+    return results.map(result => HooksRouter.stripObjectId);
+  }
+
   createHook(aHook, config) {
     return config.hooksController.createHook(aHook).then( (hook) => ({response: hook}));
   };
@@ -23,12 +33,12 @@ export class HooksRouter extends PromiseRouter {
         if (!foundFunction) {
           throw new Parse.Error(143, `no function named: ${req.params.functionName} is defined`);
         }
-        return Promise.resolve({response: foundFunction});
+        return Promise.resolve({response: HooksRouter.stripObjectId(foundFunction)});
       });
     }
-    
+
     return hooksController.getFunctions().then((functions) => {
-      return { response: functions || [] };
+      return { response: HooksRouter.stripObjectIds(functions || []) };
     }, (err) => {
       throw err;
     });
@@ -37,16 +47,17 @@ export class HooksRouter extends PromiseRouter {
   handleGetTriggers(req) {
     var hooksController = req.config.hooksController;
     if (req.params.className && req.params.triggerName) {
-      
       return hooksController.getTrigger(req.params.className, req.params.triggerName).then((foundTrigger) => {
         if (!foundTrigger) {
           throw new Parse.Error(143,`class ${req.params.className} does not exist`);
         }
-        return Promise.resolve({response: foundTrigger});
+        return Promise.resolve({response: HooksRouter.stripObjectId(foundTrigger)});
       });
     }
-    
-    return hooksController.getTriggers().then((triggers) => ({ response: triggers || [] }));
+
+    return hooksController.getTriggers().then((triggers) => {
+      return { response: HooksRouter.stripObjectIds(triggers || []) };
+    });
   }
 
   handleDelete(req) {
@@ -73,10 +84,10 @@ export class HooksRouter extends PromiseRouter {
       hook.url = req.body.url
     } else {
       throw new Parse.Error(143, "invalid hook declaration");
-    } 
+    }
     return this.updateHook(hook, req.config);
   }
-  
+
   handlePut(req) {
     var body = req.body;
     if (body.__op == "Delete") {
@@ -85,7 +96,7 @@ export class HooksRouter extends PromiseRouter {
       return this.handleUpdate(req);
     }
   }
-  
+
   mountRoutes() {
     this.route('GET',  '/hooks/functions', middleware.promiseEnforceMasterKeyAccess, this.handleGetFunctions.bind(this));
     this.route('GET',  '/hooks/triggers', middleware.promiseEnforceMasterKeyAccess, this.handleGetTriggers.bind(this));