add download

Author: dblythy

spec/CloudCode.spec.js

@@ -3531,8 +3531,7 @@ describe('afterLogin hook', () => {
 });
 
 describe('saveFile hooks', () => {
-  fit('find hooks should run', async () => {
-    await reconfigureServer({ silent: false });
+  it('find hooks should run', async () => {
     const file = new Parse.File('popeye.txt', [1, 2, 3], 'text/plain');
     await file.save({ useMasterKey: true });
     const user = await Parse.User.signUp('username', 'password');
@@ -3550,6 +3549,7 @@ describe('saveFile hooks', () => {
         expect(req.triggerName).toBe('afterFind');
         expect(req.master).toBeFalse();
         expect(req.log).toBeDefined();
+        expect(req.forceDownload).toBeFalse();
       },
     };
     for (const hook in hooks) {
@@ -3569,8 +3569,7 @@ describe('saveFile hooks', () => {
     }
   });
 
-  fit('beforeFind can throw', async () => {
-    await reconfigureServer({ silent: false });
+  it('beforeFind can throw', async () => {
     const file = new Parse.File('popeye.txt', [1, 2, 3], 'text/plain');
     await file.save({ useMasterKey: true });
     const user = await Parse.User.signUp('username', 'password');
@@ -3601,8 +3600,7 @@ describe('saveFile hooks', () => {
     expect(hooks.afterFind).not.toHaveBeenCalled();
   });
 
-  fit('afterFind can throw', async () => {
-    await reconfigureServer({ silent: false });
+  it('afterFind can throw', async () => {
     const file = new Parse.File('popeye.txt', [1, 2, 3], 'text/plain');
     await file.save({ useMasterKey: true });
     const user = await Parse.User.signUp('username', 'password');
@@ -3633,6 +3631,24 @@ describe('saveFile hooks', () => {
     }
   });
 
+  it('can force download', async () => {
+    const file = new Parse.File('popeye.txt', [1, 2, 3], 'text/plain');
+    await file.save({ useMasterKey: true });
+    const user = await Parse.User.signUp('username', 'password');
+    Parse.Cloud.afterFind(Parse.File, req => {
+      req.forceDownload = true;
+    });
+    const response = await request({
+      url: file.url(),
+      headers: {
+        'X-Parse-Application-Id': 'test',
+        'X-Parse-REST-API-Key': 'rest',
+        'X-Parse-Session-Token': user.getSessionToken(),
+      },
+    });
+    expect(response.headers['content-disposition']).toBe(`attachment;filename=${file._name}`);
+  });
+
   it('beforeSaveFile should return file that is already saved and not save anything to files adapter', async () => {
     await reconfigureServer({ filesAdapter: mockAdapter });
     const createFileSpy = spyOn(mockAdapter, 'createFile').and.callThrough();

src/Routers/FilesRouter.js

@@ -112,7 +112,7 @@ export class FilesRouter {
       file = new Parse.File(filename, { base64: data.toString('base64') }, contentType);
       const afterFind = await triggers.maybeRunFileTrigger(
         triggers.Types.afterFind,
-        { file },
+        { file, forceDownload: false },
         config,
         req.auth
       );
@@ -125,6 +125,9 @@ export class FilesRouter {
       res.status(200);
       res.set('Content-Type', contentType);
       res.set('Content-Length', data.length);
+      if (afterFind.forceDownload) {
+        res.set('Content-Disposition', `attachment;filename=${afterFind.file._name}`);
+      }
       res.end(data);
     } catch (e) {
       const err = triggers.resolveError(e, {

src/triggers.js

@@ -1004,6 +1004,9 @@ export async function maybeRunFileTrigger(triggerType, fileObject, config, auth)
         return fileObject;
       }
       const result = await fileTrigger(request);
+      if (request.forceDownload) {
+        fileObject.forceDownload = true;
+      }
       logTriggerSuccessBeforeHook(
         triggerType,
         'Parse.File',