Skip to content

Commit 34453bf

Browse files
authored
PostgreSQL performance optimization (#4457)
Performance-optimizing transactions to execute all non-result queries as a single operation.
1 parent 415ee3a commit 34453bf

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/Adapters/Storage/Postgres/PostgresStorageAdapter.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -802,7 +802,8 @@ export class PostgresStorageAdapter {
802802
return list.concat(joinTablesForSchema(schema.schema));
803803
}, []);
804804
const classes = ['_SCHEMA', '_PushStatus', '_JobStatus', '_JobSchedule', '_Hooks', '_GlobalConfig', '_Audience', ...results.map(result => result.className), ...joins];
805-
return this._client.tx(t=>t.batch(classes.map(className=>t.none('DROP TABLE IF EXISTS $<className:name>', {className}))));
805+
const queries = classes.map(className => ({query: 'DROP TABLE IF EXISTS $<className:name>', values: {className}}));
806+
return this._client.tx(t => t.none(this._pgp.helpers.concat(queries)));
806807
}, error => {
807808
if (error.code === PostgresRelationDoesNotExistError) {
808809
// No _SCHEMA collection. Don't delete anything.
@@ -1598,7 +1599,8 @@ export class PostgresStorageAdapter {
15981599
}
15991600

16001601
dropIndexes(className, indexes, conn) {
1601-
return (conn || this._client).tx(t => t.batch(indexes.map(i => t.none('DROP INDEX $1:name', i))));
1602+
const queries = indexes.map(i => ({query: 'DROP INDEX $1:name', values: i}));
1603+
return (conn || this._client).tx(t => t.none(this._pgp.helpers.concat(queries)));
16021604
}
16031605

16041606
getIndexes(className) {

0 commit comments

Comments
 (0)